refactor: menu component props and toolbar menu item colors [skip e2e]

This commit is contained in:
Aman Harwara
2023-10-25 20:29:08 +05:30
parent cbc93fea13
commit 9e784d0c1c
31 changed files with 34 additions and 54 deletions

View File

@@ -79,7 +79,7 @@ const AddItemMenuButton = ({
align="center"
className="py-2"
>
<Menu a11yLabel={'test'} isOpen={isMenuOpen}>
<Menu a11yLabel={'test'}>
<MenuItem
onClick={() => {
addNewItem()

View File

@@ -125,7 +125,6 @@ const ContentListHeader = ({
<DisplayOptionsMenu
application={application}
isFilesSmartView={isFilesSmartView}
isOpen={showDisplayOptionsMenu}
selectedTag={selectedTag}
paneController={paneController}
/>

View File

@@ -82,7 +82,6 @@ const TabButton: FunctionComponent<{
const DisplayOptionsMenu: FunctionComponent<DisplayOptionsMenuProps> = ({
application,
isOpen,
isFilesSmartView,
selectedTag,
paneController,
@@ -283,7 +282,7 @@ const DisplayOptionsMenu: FunctionComponent<DisplayOptionsMenuProps> = ({
const shouldHideNonApplicableOptions = isTableViewEnabled && !isMobileScreen
return (
<Menu className="text-sm" a11yLabel="Notes list options menu" isOpen={isOpen}>
<Menu className="text-sm" a11yLabel="Notes list options menu">
<div className="my-1 px-3 text-base font-semibold uppercase text-text lg:text-xs">Preferences for</div>
<div className={classNames('mt-1.5 flex w-full justify-between px-3', !controlsDisabled && 'mb-3')}>
<div className="flex items-center gap-1.5">

View File

@@ -10,7 +10,6 @@ export type DisplayOptionsMenuPositionProps = {
export type DisplayOptionsMenuProps = {
application: WebApplication
selectedTag: AnyTag
isOpen: boolean
isFilesSmartView: boolean
paneController: PaneController
}