From a07fa23c70a8d1b746c26bdfb78fbad14214fd87 Mon Sep 17 00:00:00 2001
From: Aman Harwara <amanharwara@protonmail.com>
Date: Wed, 13 Sep 2023 15:59:57 +0530
Subject: [PATCH] refactor: radio button group value generic

---
 .../Components/RadioButtonGroup/RadioButtonGroup.tsx | 12 ++++++------
 .../VaultSelectionMenu/VaultSelectionMenu.tsx        |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/packages/web/src/javascripts/Components/RadioButtonGroup/RadioButtonGroup.tsx b/packages/web/src/javascripts/Components/RadioButtonGroup/RadioButtonGroup.tsx
index acfef9e09..ae6206bf4 100644
--- a/packages/web/src/javascripts/Components/RadioButtonGroup/RadioButtonGroup.tsx
+++ b/packages/web/src/javascripts/Components/RadioButtonGroup/RadioButtonGroup.tsx
@@ -1,19 +1,19 @@
 import { VisuallyHidden, Radio, RadioGroup, useRadioStore } from '@ariakit/react'
 import { classNames } from '@standardnotes/utils'
 
-type Props = {
-  items: { label: string; value: string }[]
-  value: string
-  onChange: (value: string) => void
+type Props<Value extends string> = {
+  items: { label: string; value: Value }[]
+  value: Value
+  onChange: (value: Value) => void
   className?: string
 }
 
-const RadioButtonGroup = ({ value, items, onChange, className }: Props) => {
+function RadioButtonGroup<Value extends string>({ value, items, onChange, className }: Props<Value>) {
   const radio = useRadioStore({
     value,
     orientation: 'horizontal',
     setValue(value) {
-      onChange(value as string)
+      onChange(value as Value)
     },
   })
 
diff --git a/packages/web/src/javascripts/Components/VaultSelectionMenu/VaultSelectionMenu.tsx b/packages/web/src/javascripts/Components/VaultSelectionMenu/VaultSelectionMenu.tsx
index f981bc2c4..c0fb6cf8a 100644
--- a/packages/web/src/javascripts/Components/VaultSelectionMenu/VaultSelectionMenu.tsx
+++ b/packages/web/src/javascripts/Components/VaultSelectionMenu/VaultSelectionMenu.tsx
@@ -35,7 +35,7 @@ const VaultSelectionMenu = () => {
           { label: 'One', value: 'single' },
         ]}
         value={mode}
-        onChange={(value) => changeSelectionMode(value as SettingsMode)}
+        onChange={(value) => changeSelectionMode(value)}
         className="m-3 mt-1"
       />
       {mode === 'many' && <ManyVaultSelectionMenu />}