refactor: pass sub controllers to controllers instead of passing global controller manager (#1061)

app/assets/javascripts/Controllers/NoAccountWarningController.ts

@@ -1,5 +1,5 @@
 import { storage, StorageKey } from '@/Services/LocalStorage'
-import { ApplicationEvent } from '@standardnotes/snjs'
+import { ApplicationEvent, InternalEventBus } from '@standardnotes/snjs'
 import { runInAction, makeObservable, observable, action } from 'mobx'
 import { WebApplication } from '../Application/Application'
 import { AbstractViewController } from './Abstract/AbstractViewController'
@@ -7,17 +7,20 @@ import { AbstractViewController } from './Abstract/AbstractViewController'
 export class NoAccountWarningController extends AbstractViewController {
   show: boolean
 
-  constructor(application: WebApplication, appObservers: (() => void)[]) {
-    super(application)
+  constructor(application: WebApplication, eventBus: InternalEventBus) {
+    super(application, eventBus)
 
     this.show = application.hasAccount() ? false : storage.get(StorageKey.ShowNoAccountWarning) ?? true
 
-    appObservers.push(
+    this.disposers.push(
       application.addEventObserver(async () => {
         runInAction(() => {
           this.show = false
         })
       }, ApplicationEvent.SignedIn),
+    )
+
+    this.disposers.push(
       application.addEventObserver(async () => {
         if (application.hasAccount()) {
           runInAction(() => {