refactor: improve device interface types (#996)

app/assets/javascripts/Components/ApplicationView/index.tsx

@@ -59,7 +59,11 @@ export class ApplicationView extends PureComponent<Props, State> {
   }
 
   async loadApplication() {
-    this.application.componentManager.setDesktopManager(this.application.getDesktopService())
+    const desktopService = this.application.getDesktopService()
+    if (desktopService) {
+      this.application.componentManager.setDesktopManager(desktopService)
+    }
+
     await this.application.prepareForLaunch({
       receiveChallenge: async (challenge) => {
         const challenges = this.state.challenges.slice()
@@ -67,6 +71,7 @@ export class ApplicationView extends PureComponent<Props, State> {
         this.setState({ challenges: challenges })
       },
     })
+
     await this.application.launch()
   }
 

app/assets/javascripts/Components/ComponentView/index.tsx

@@ -168,14 +168,14 @@ export const ComponentView: FunctionalComponent<IProps> = observer(
     useEffect(() => {
       const unregisterDesktopObserver = application
         .getDesktopService()
-        .registerUpdateObserver((updatedComponent: SNComponent) => {
+        ?.registerUpdateObserver((updatedComponent: SNComponent) => {
           if (updatedComponent.uuid === component.uuid && updatedComponent.active) {
             requestReload?.(componentViewer)
           }
         })
 
       return () => {
-        unregisterDesktopObserver()
+        unregisterDesktopObserver?.()
       }
     }, [application, requestReload, componentViewer, component.uuid])
 

app/assets/javascripts/Components/ConfirmSignoutModal/index.tsx

@@ -28,8 +28,8 @@ export const ConfirmSignoutModal = observer(({ application, appState }: Props) =
   const [localBackupsCount, setLocalBackupsCount] = useState(0)
 
   useEffect(() => {
-    application.bridge.localBackupsCount().then(setLocalBackupsCount).catch(console.error)
-  }, [appState.accountMenu.signingOut, application.bridge])
+    application.desktopDevice?.localBackupsCount().then(setLocalBackupsCount).catch(console.error)
+  }, [appState.accountMenu.signingOut, application.desktopDevice])
 
   return (
     <AlertDialog onDismiss={closeDialog} leastDestructiveRef={cancelRef}>
@@ -44,6 +44,7 @@ export const ConfirmSignoutModal = observer(({ application, appState }: Props) =
                 <AlertDialogDescription className="sk-panel-row">
                   <p className="color-foreground">{STRING_SIGN_OUT_CONFIRMATION}</p>
                 </AlertDialogDescription>
+
                 {localBackupsCount > 0 && (
                   <div className="flex">
                     <div className="sk-panel-row"></div>
@@ -63,13 +64,14 @@ export const ConfirmSignoutModal = observer(({ application, appState }: Props) =
                     <button
                       className="capitalize sk-a ml-1.5 p-0 rounded cursor-pointer"
                       onClick={() => {
-                        application.bridge.viewlocalBackups()
+                        application.desktopDevice?.viewlocalBackups()
                       }}
                     >
                       View backup files
                     </button>
                   </div>
                 )}
+
                 <div className="flex my-1 mt-4">
                   <button className="sn-button small neutral" ref={cancelRef} onClick={closeDialog}>
                     Cancel

app/assets/javascripts/Components/NoteView/NoteView.tsx

@@ -147,7 +147,7 @@ export class NoteView extends PureComponent<Props, State> {
     this.controller = props.controller
 
     this.onEditorComponentLoad = () => {
-      this.application.getDesktopService().redoSearch()
+      this.application.getDesktopService()?.redoSearch()
     }
 
     this.debounceReloadEditorComponent = debounce(this.debounceReloadEditorComponent.bind(this), 25)