From ac24256f347cc7d13cfa280666720eadb4106970 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Karol=20S=C3=B3jko?= Date: Fri, 5 Aug 2022 13:54:16 +0200 Subject: [PATCH] chore(setup): run linter before building on workflows --- .github/workflows/pr.yml | 24 +++++++++++++++++-- .github/workflows/publish.yml | 24 ++++++++++++++++--- .github/workflows/web.release.prod.yml | 33 +++++++++++++++++++++++--- 3 files changed, 73 insertions(+), 8 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index f86c3fc60..c62f82ff1 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -9,17 +9,37 @@ on: - '!packages/components/**' jobs: + lint: + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v3 + - name: Set up Node + uses: actions/setup-node@v3 + with: + registry-url: 'https://registry.npmjs.org' + node-version-file: '.nvmrc' + cache: 'yarn' + - name: Install dependencies + run: yarn install --immutable + - name: ESLint + run: yarn lint + test: runs-on: ubuntu-latest steps: - name: Checkout code uses: actions/checkout@v3 + - name: Set up Node + uses: actions/setup-node@v3 + with: + registry-url: 'https://registry.npmjs.org' + node-version-file: '.nvmrc' + cache: 'yarn' - name: Install dependencies run: yarn install --immutable - name: Build run: yarn build:all - - name: ESLint - run: yarn lint - name: Build Android run: yarn android:bundle - name: Test diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index cdfc9ddbf..e7c2127c4 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -5,8 +5,29 @@ on: branches: [ main ] jobs: + Lint: + if: "${{ contains(github.event.head_commit.message, 'chore(release): publish') == false }}" + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v3 + + - name: Set up Node + uses: actions/setup-node@v3 + with: + registry-url: 'https://registry.npmjs.org' + node-version-file: '.nvmrc' + cache: 'yarn' + + - name: Install dependencies + run: yarn install --immutable + + - name: ESLint + run: yarn lint + Build: if: "${{ contains(github.event.head_commit.message, 'chore(release): publish') == false }}" + needs: Lint runs-on: ubuntu-latest steps: - name: Checkout code @@ -40,9 +61,6 @@ jobs: - name: Build run: yarn build:all - - name: ESLint - run: yarn lint - - name: Build Android run: yarn android:bundle diff --git a/.github/workflows/web.release.prod.yml b/.github/workflows/web.release.prod.yml index 51f1ae7c3..b3afda376 100644 --- a/.github/workflows/web.release.prod.yml +++ b/.github/workflows/web.release.prod.yml @@ -12,27 +12,54 @@ on: - '!*standardnotes/*web*alpha*' jobs: + lint: + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v3 + - name: Set up Node + uses: actions/setup-node@v3 + with: + registry-url: 'https://registry.npmjs.org' + node-version-file: '.nvmrc' + cache: 'yarn' + - name: Install dependencies + run: yarn install --immutable + - name: ESLint + run: yarn lint + test: runs-on: ubuntu-latest steps: - name: Checkout code uses: actions/checkout@v3 + - name: Set up Node + uses: actions/setup-node@v3 + with: + registry-url: 'https://registry.npmjs.org' + node-version-file: '.nvmrc' + cache: 'yarn' - name: Install dependencies run: yarn install --immutable - name: Build run: yarn build:web - - name: ESLint - run: yarn lint - name: Test run: yarn test + deploy: - needs: test + needs: [lint, test] runs-on: ubuntu-latest steps: - name: Checkout code uses: actions/checkout@v3 + - name: Set up Node + uses: actions/setup-node@v3 + with: + registry-url: 'https://registry.npmjs.org' + node-version-file: '.nvmrc' + cache: 'yarn' - name: Install dependencies run: yarn install --immutable - name: Build