rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: object url not being revoked on modal close (#1044)

Browse Source
This commit is contained in:
Aman Harwara
2022-05-24 02:42:56 +05:30
committed by GitHub
parent dea54fbf23
commit acdf442e61
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/Components/ApplicationView/ApplicationView.tsx
View File

@@ -20,7 +20,7 @@ import { PremiumModalProvider } from '@/Hooks/usePremiumModal'
import { ConfirmSignoutContainer } from '@/Components/ConfirmSignoutModal/ConfirmSignoutModal' import { ConfirmSignoutContainer } from '@/Components/ConfirmSignoutModal/ConfirmSignoutModal'
import { TagsContextMenu } from '@/Components/Tags/TagContextMenu' import { TagsContextMenu } from '@/Components/Tags/TagContextMenu'
import { ToastContainer } from '@standardnotes/stylekit' import { ToastContainer } from '@standardnotes/stylekit'
import { FilePreviewModal } from '@/Components/Files/FilePreviewModal' import { FilePreviewModalWrapper } from '@/Components/Files/FilePreviewModal'
import { useCallback, useEffect, useMemo, useState } from 'preact/hooks' import { useCallback, useEffect, useMemo, useState } from 'preact/hooks'
import { isStateDealloced } from '@/UIModels/AppState/AbstractState' import { isStateDealloced } from '@/UIModels/AppState/AbstractState'
import { ContentListView } from '@/Components/ContentListView/ContentListView' import { ContentListView } from '@/Components/ContentListView/ContentListView'
@@ -236,7 +236,7 @@ export const ApplicationView: FunctionComponent<Props> = ({ application, mainApp
application={application} application={application}
/> />
<ToastContainer /> <ToastContainer />
<FilePreviewModal application={application} appState={appState} /> <FilePreviewModalWrapper application={application} appState={appState} />
</> </>
</div> </div>
</PremiumModalProvider> </PremiumModalProvider>

10
app/assets/javascripts/Components/Files/FilePreviewModal.tsx
View File

@@ -21,10 +21,14 @@ type Props = {
appState: AppState appState: AppState
} }
export const FilePreviewModal: FunctionComponent<Props> = observer(({ application, appState }) => { export const FilePreviewModalWrapper: FunctionComponent<Props> = observer(({ application, appState }) => {
const { currentFile, setCurrentFile, otherFiles, dismiss, isOpen } = appState.filePreviewModal return appState.filePreviewModal.isOpen ? <FilePreviewModal application={application} appState={appState} /> : null
})
if (!currentFile || !isOpen) { const FilePreviewModal: FunctionComponent<Props> = observer(({ application, appState }) => {
const { currentFile, setCurrentFile, otherFiles, dismiss } = appState.filePreviewModal
if (!currentFile) {
return null return null
} }