refactor: move observers and streamers to separate methods, code cleanup

app/assets/javascripts/ui_models/app_state/account_menu_state.ts

@@ -16,8 +16,7 @@ export class AccountMenuState {
 
   constructor(
     private application: WebApplication,
-    appObservers: (() => void)[],
+    private appEventListeners: (() => void)[]
-    appEventListeners: (() => void)[]
   ) {
     makeObservable(this, {
       show: observable,
@@ -40,15 +39,22 @@ export class AccountMenuState {
       notesAndTagsCount: computed
     });
 
-    appObservers.push(
+    this.addAppEventObserver();
-      application.addEventObserver(async () => {
+    this.streamNotesAndTags();
+  }
+
+  addAppEventObserver = (): void => {
+    this.appEventListeners.push(
+      this.application.addEventObserver(async () => {
         runInAction(() => {
           this.setServer(this.application.getHost());
         });
       }, ApplicationEvent.Launched)
     );
+  };
 
-    appEventListeners.push(
+  streamNotesAndTags = (): void => {
+    this.appEventListeners.push(
       this.application.streamItems(
         [ContentType.Note, ContentType.Tag],
         () => {
@@ -58,7 +64,7 @@ export class AccountMenuState {
         }
       )
     );
-  }
+  };
 
   setShow = (show: boolean): void => {
     this.show = show;

app/assets/javascripts/ui_models/app_state/app_state.ts

@@ -107,7 +107,6 @@ export class AppState {
     this.accountMenu = new AccountMenuState(
       application,
       this.appEventObserverRemovers,
-      this.appEventObserverRemovers
     );
     this.searchOptions = new SearchOptionsState(
       application,