From bb63cbe2d15dd47d62a2cc34f824ed4bec6091de Mon Sep 17 00:00:00 2001 From: Aman Harwara Date: Sun, 23 Oct 2022 21:46:23 +0530 Subject: [PATCH] fix: listed menu closing when clicking inside challenge modal (#1863) --- .../Components/Popover/Utils/usePopoverCloseOnClickOutside.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/web/src/javascripts/Components/Popover/Utils/usePopoverCloseOnClickOutside.ts b/packages/web/src/javascripts/Components/Popover/Utils/usePopoverCloseOnClickOutside.ts index f4ca9b192..d3b01baf3 100644 --- a/packages/web/src/javascripts/Components/Popover/Utils/usePopoverCloseOnClickOutside.ts +++ b/packages/web/src/javascripts/Components/Popover/Utils/usePopoverCloseOnClickOutside.ts @@ -28,8 +28,9 @@ export const usePopoverCloseOnClickOutside = ({ const isAnchorElement = anchorElement ? anchorElement === event.target || anchorElement.contains(target) : false const closestPopoverId = target.closest('[data-popover]')?.getAttribute('data-popover') const isDescendantOfChildPopover = closestPopoverId && childPopovers.has(closestPopoverId) + const isDescendantOfChallengeModal = !!target.closest('.challenge-modal') - if (!isDescendantOfMenu && !isAnchorElement && !isDescendantOfChildPopover) { + if (!isDescendantOfMenu && !isAnchorElement && !isDescendantOfChildPopover && !isDescendantOfChallengeModal) { togglePopover() } }