From be6a9fdb34f297891b98e6dbef19fc0b101009a9 Mon Sep 17 00:00:00 2001
From: Aman Harwara <amanharwara@protonmail.com>
Date: Thu, 10 Mar 2022 20:57:59 +0530
Subject: [PATCH] feat: wrap search option bubbles if not enough space (#918)

---
 app/assets/javascripts/components/Bubble.tsx        |  3 +--
 app/assets/javascripts/components/NotesView.tsx     |  2 +-
 app/assets/javascripts/components/SearchOptions.tsx |  6 +-----
 app/assets/stylesheets/_notes.scss                  | 12 ++++--------
 4 files changed, 7 insertions(+), 16 deletions(-)

diff --git a/app/assets/javascripts/components/Bubble.tsx b/app/assets/javascripts/components/Bubble.tsx
index e164a4f50..5e6a157dc 100644
--- a/app/assets/javascripts/components/Bubble.tsx
+++ b/app/assets/javascripts/components/Bubble.tsx
@@ -12,8 +12,7 @@ const styles = {
 
 const Bubble = ({ label, selected, onSelect }: BubbleProperties) => (
   <span
-    role="tab"
-    className={`bubble ${styles.base} ${
+    className={`${styles.base} ${
       selected ? styles.selected : styles.unselected
     }`}
     onClick={onSelect}
diff --git a/app/assets/javascripts/components/NotesView.tsx b/app/assets/javascripts/components/NotesView.tsx
index 6c6a19f23..cd869a693 100644
--- a/app/assets/javascripts/components/NotesView.tsx
+++ b/app/assets/javascripts/components/NotesView.tsx
@@ -182,7 +182,7 @@ export const NotesView: FunctionComponent<Props> = observer(
                 </button>
               </div>
               <div className="filter-section" role="search">
-                <div>
+                <div className="relative">
                   <input
                     type="text"
                     id="search-bar"
diff --git a/app/assets/javascripts/components/SearchOptions.tsx b/app/assets/javascripts/components/SearchOptions.tsx
index c6abf6e0e..9d8c0b20d 100644
--- a/app/assets/javascripts/components/SearchOptions.tsx
+++ b/app/assets/javascripts/components/SearchOptions.tsx
@@ -19,11 +19,7 @@ export const SearchOptions = observer(({ appState }: Props) => {
   }
 
   return (
-    <div
-      role="tablist"
-      className="search-options justify-center"
-      onMouseDown={(e) => e.preventDefault()}
-    >
+    <div className="search-options" onMouseDown={(e) => e.preventDefault()}>
       <Bubble
         label="Protected Contents"
         selected={includeProtectedContents}
diff --git a/app/assets/stylesheets/_notes.scss b/app/assets/stylesheets/_notes.scss
index 3e8cf1cd1..f9c71eb1d 100644
--- a/app/assets/stylesheets/_notes.scss
+++ b/app/assets/stylesheets/_notes.scss
@@ -52,7 +52,6 @@
 
   .filter-section {
     clear: left;
-    max-height: 80px;
     margin-top: 10px;
     position: relative;
     display: flex;
@@ -77,14 +76,11 @@
     .search-options {
       margin-top: 10px;
 
-      display: grid;
-      grid-template-columns: repeat( 3, 1fr );
-      gap: .5rem;
+      display: flex;
+      flex-wrap: wrap;
+      gap: 0.5rem;
 
       font-size: var(--sn-stylekit-font-size-p);
-      white-space: nowrap;
-
-      overflow-x: auto;
     }
 
     #search-clear-button {
@@ -100,7 +96,7 @@
       line-height: 17px;
       text-align: center;
       position: absolute;
-      top: 20%;
+      top: 50%;
       transform: translateY(-50%);
       right: 10px;
       cursor: pointer;