From c0759980cccbac53945e7bf58a6b0e25b93f63d8 Mon Sep 17 00:00:00 2001 From: Baptiste Grob <60621355+baptiste-grob@users.noreply.github.com> Date: Tue, 4 Feb 2020 14:21:32 +0100 Subject: [PATCH] eslint --fix: 'expression ? true : false' => '!!expression' --- app/assets/javascripts/controllers/notes/note_utils.js | 2 +- app/assets/javascripts/directives/views/componentView.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/controllers/notes/note_utils.js b/app/assets/javascripts/controllers/notes/note_utils.js index c2425c969..2e4a62662 100644 --- a/app/assets/javascripts/controllers/notes/note_utils.js +++ b/app/assets/javascripts/controllers/notes/note_utils.js @@ -102,7 +102,7 @@ function stringIsUuid(text) { const matches = text.match( /\b[0-9a-f]{8}\b-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-\b[0-9a-f]{12}\b/ ); - return matches ? true : false; + return !!matches; } export function sortNotes({ diff --git a/app/assets/javascripts/directives/views/componentView.js b/app/assets/javascripts/directives/views/componentView.js index f8d0c4c21..811122a55 100644 --- a/app/assets/javascripts/directives/views/componentView.js +++ b/app/assets/javascripts/directives/views/componentView.js @@ -193,7 +193,7 @@ class ComponentViewCtrl { const avoidFlickerTimeout = 7; this.$timeout(() => { this.loading = false; - this.issueLoading = desktopError ? true : false; + this.issueLoading = !!desktopError; this.onLoad && this.onLoad(this.component); }, avoidFlickerTimeout); }