rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: modifier-only key observers not working (#1009)

Browse Source
This commit is contained in:
Aman Harwara
2022-05-04 14:01:53 +05:30
committed by GitHub
parent 43d94fbcbf
commit c7e849ac90
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/Services/IOService.ts
View File

@@ -142,7 +142,7 @@ export class IOService {
private eventMatchesKeyAndModifiers( private eventMatchesKeyAndModifiers(
event: KeyboardEvent, event: KeyboardEvent,
key: KeyboardKey | string, key: KeyboardKey | string | undefined,
modifiers: KeyboardModifier[] = [], modifiers: KeyboardModifier[] = [],
): boolean { ): boolean {
const eventModifiers = this.modifiersForEvent(event) const eventModifiers = this.modifiersForEvent(event)
@@ -186,7 +186,7 @@ export class IOService {
continue continue
} }
if (observer.key && this.eventMatchesKeyAndModifiers(event, observer.key, observer.modifiers)) { if (this.eventMatchesKeyAndModifiers(event, observer.key, observer.modifiers)) {
const callback = keyEvent === KeyboardKeyEvent.Down ? observer.onKeyDown : observer.onKeyUp const callback = keyEvent === KeyboardKeyEvent.Down ? observer.onKeyDown : observer.onKeyUp
if (callback) { if (callback) {
callback(event) callback(event)