From c9a95c818b88a0a9ab6f046eb5d5b48ce2faa850 Mon Sep 17 00:00:00 2001
From: Aman Harwara <amanharwara@protonmail.com>
Date: Fri, 30 Jun 2023 20:56:48 +0530
Subject: [PATCH] chore: fix session modal error after revoking session

---
 .../Components/SessionsModal/SessionsModal.tsx         | 10 ++++------
 .../javascripts/Controllers/ViewControllerManager.ts   |  4 ++--
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/packages/web/src/javascripts/Components/SessionsModal/SessionsModal.tsx b/packages/web/src/javascripts/Components/SessionsModal/SessionsModal.tsx
index 669f0c394..b15302c53 100644
--- a/packages/web/src/javascripts/Components/SessionsModal/SessionsModal.tsx
+++ b/packages/web/src/javascripts/Components/SessionsModal/SessionsModal.tsx
@@ -1,6 +1,6 @@
 import { ViewControllerManager } from '@/Controllers/ViewControllerManager'
 import { SNApplication, SessionStrings, UuidString, SessionListEntry, isErrorResponse } from '@standardnotes/snjs'
-import { FunctionComponent, useState, useEffect, useRef, useMemo, useCallback } from 'react'
+import { FunctionComponent, useState, useEffect, useRef, useMemo } from 'react'
 import { WebApplication } from '@/Application/WebApplication'
 import { observer } from 'mobx-react-lite'
 import Spinner from '@/Components/Spinner/Spinner'
@@ -80,8 +80,6 @@ const SessionsModalContent: FunctionComponent<{
   viewControllerManager: ViewControllerManager
   application: SNApplication
 }> = ({ viewControllerManager, application }) => {
-  const close = useCallback(() => viewControllerManager.closeSessionsModal(), [viewControllerManager])
-
   const [sessions, refresh, refreshing, revokeSession, errorMessage] = useSessions(application)
 
   const [confirmRevokingSessionUuid, setRevokingSessionUuid] = useState('')
@@ -109,7 +107,7 @@ const SessionsModalContent: FunctionComponent<{
     (): ModalAction[] => [
       {
         label: 'Close',
-        onClick: close,
+        onClick: viewControllerManager.closeSessionsModal,
         type: 'cancel',
         mobileSlot: 'left',
       },
@@ -120,14 +118,14 @@ const SessionsModalContent: FunctionComponent<{
         mobileSlot: 'right',
       },
     ],
-    [close, refresh],
+    [refresh, viewControllerManager.closeSessionsModal],
   )
 
   return (
     <>
       <Modal
         title="Active Sessions"
-        close={close}
+        close={viewControllerManager.closeSessionsModal}
         actions={sessionModalActions}
         className={{
           content: 'sessions-modal',
diff --git a/packages/web/src/javascripts/Controllers/ViewControllerManager.ts b/packages/web/src/javascripts/Controllers/ViewControllerManager.ts
index 8b332cd17..60aa7a32e 100644
--- a/packages/web/src/javascripts/Controllers/ViewControllerManager.ts
+++ b/packages/web/src/javascripts/Controllers/ViewControllerManager.ts
@@ -263,11 +263,11 @@ export class ViewControllerManager implements InternalEventHandlerInterface {
     destroyAllObjectProperties(this)
   }
 
-  openSessionsModal(): void {
+  openSessionsModal = () => {
     this.isSessionsModalVisible = true
   }
 
-  closeSessionsModal(): void {
+  closeSessionsModal = () => {
     this.isSessionsModalVisible = false
   }