feat: add Super note type to list of note types (#2086)

packages/snjs/lib/Services/Features/FeaturesService.spec.ts

@@ -197,7 +197,7 @@ describe('featuresService', () => {
 
   describe('loadUserRoles()', () => {
     it('retrieves user roles and features from storage', async () => {
-      await createService().initializeFromDisk()
+      createService().initializeFromDisk()
       expect(storageService.getValue).toHaveBeenCalledWith(StorageKey.UserRoles, undefined, [])
       expect(storageService.getValue).toHaveBeenCalledWith(StorageKey.UserFeatures, undefined, [])
     })
@@ -576,6 +576,14 @@ describe('featuresService', () => {
       expect(featuresService.getFeatureStatus(FeatureIdentifier.SheetsEditor)).toBe(FeatureStatus.NotInCurrentPlan)
     })
 
+    it('availableInRoles-based features', async () => {
+      const featuresService = createService()
+
+      await featuresService.updateRolesAndFetchFeatures('123', [RoleName.ProUser])
+
+      expect(featuresService.getFeatureStatus(FeatureIdentifier.SuperEditor)).toBe(FeatureStatus.Entitled)
+    })
+
     it('third party feature status', async () => {
       const featuresService = createService()
 

packages/snjs/lib/Services/Features/FeaturesService.ts

@@ -506,13 +506,11 @@ export class SNFeaturesService
       return FeatureStatus.Entitled
     }
 
-    if (this.isExperimentalFeature(featureId)) {
-      const nativeFeature = FeaturesImports.FindNativeFeature(featureId)
-      if (nativeFeature) {
-        const hasRole = this.roles.some((role) => nativeFeature.availableInRoles?.includes(role))
-        if (hasRole) {
-          return FeatureStatus.Entitled
-        }
+    const nativeFeature = FeaturesImports.FindNativeFeature(featureId)
+    if (nativeFeature && nativeFeature.availableInRoles) {
+      const hasRole = this.roles.some((role) => nativeFeature.availableInRoles?.includes(role))
+      if (hasRole) {
+        return FeatureStatus.Entitled
       }
     }
 
@@ -525,7 +523,7 @@ export class SNFeaturesService
       }
     }
 
-    const isThirdParty = FeaturesImports.FindNativeFeature(featureId) == undefined
+    const isThirdParty = nativeFeature == undefined
     if (isThirdParty) {
       const component = this.itemManager
         .getDisplayableComponents()

packages/snjs/package.json

@@ -28,7 +28,7 @@
     "lint:eslint": "eslint --ext .ts lib/",
     "lint:fix": "eslint --fix --ext .ts lib/",
     "lint:tsc": "tsc --noEmit --emitDeclarationOnly false --project lib/tsconfig.json",
-    "test": "jest spec --coverage",
+    "test": "jest --coverage",
     "test:debug": "node --inspect-brk node_modules/.bin/jest --runInBand"
   },
   "devDependencies": {