rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge remote-tracking branch 'origin/fix/application-group-improvments' into 004

Browse Source
This commit is contained in:
Baptiste Grob
2020-06-29 17:55:23 +02:00
parent 81f32f8cca 3b3c2d6fe4
commit cb807bdbef
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/assets/javascripts/ui_models/application_group.ts
View File

@@ -15,7 +15,7 @@ import { AppState } from '@/ui_models/app_state';
type AppManagerChangeCallback = () => void type AppManagerChangeCallback = () => void
export class ApplicationGroup { export class ApplicationGroup {
$compile: ng.ICompileService $compile: ng.ICompileService
$rootScope: ng.IRootScopeService $rootScope: ng.IRootScopeService
$timeout: ng.ITimeoutService $timeout: ng.ITimeoutService
@@ -50,8 +50,9 @@ export class ApplicationGroup {
} }
if (this.applications.length === 0) { if (this.applications.length === 0) {
this.createDefaultApplication(); this.createDefaultApplication();
} else {
this.notifyObserversOfAppChange();
} }
this.notifyObserversOfAppChange();
} }
private createNewApplication() { private createNewApplication() {
@@ -121,6 +122,11 @@ export class ApplicationGroup {
if (this.application) { if (this.application) {
callback(); callback();
} }
return () => {
const indexOfObserver = this.changeObservers.indexOf(callback);
this.changeObservers.splice(indexOfObserver, 1);
}
} }
private notifyObserversOfAppChange() { private notifyObserversOfAppChange() {