fix(snjs): bring back history tests and fix handlinf of error with revisions
This commit is contained in:
@@ -155,4 +155,18 @@ describe('GetRevision', () => {
|
||||
|
||||
expect(result.isFailed()).toBe(true)
|
||||
})
|
||||
|
||||
it('should fail if revision manager throws', async () => {
|
||||
revisionManager.getRevision = jest.fn().mockRejectedValue(new Error('error'))
|
||||
|
||||
const useCase = createUseCase()
|
||||
|
||||
const result = await useCase.execute({
|
||||
itemUuid: '00000000-0000-0000-0000-000000000000',
|
||||
revisionUuid: '00000000-0000-0000-0000-000000000000',
|
||||
})
|
||||
|
||||
expect(result.isFailed()).toBe(true)
|
||||
expect(result.getError()).toEqual('Could not get revision: error')
|
||||
})
|
||||
})
|
||||
|
||||
@@ -29,8 +29,14 @@ export class GetRevision implements UseCaseInterface<HistoryEntry> {
|
||||
}
|
||||
const revisionUuid = revisionUuidOrError.getValue()
|
||||
|
||||
const revision = await this.revisionManager.getRevision(itemUuid, revisionUuid)
|
||||
if (revision === null) {
|
||||
let revision
|
||||
try {
|
||||
revision = await this.revisionManager.getRevision(itemUuid, revisionUuid)
|
||||
} catch (error) {
|
||||
return Result.fail(`Could not get revision: ${(error as Error).message}`)
|
||||
}
|
||||
|
||||
if (!revision) {
|
||||
return Result.fail('Could not get revision: Revision not found')
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user