fix(snjs): bring back history tests and fix handlinf of error with revisions

This commit is contained in:
Karol Sójko
2023-01-20 10:02:48 +01:00
parent e61ac4c54a
commit cb9c16047e
8 changed files with 75 additions and 34 deletions

View File

@@ -29,4 +29,15 @@ describe('ListRevisions', () => {
expect(result.isFailed()).toBe(true)
expect(result.getError()).toEqual('Could not list item revisions: Given value is not a valid uuid: invalid')
})
it('should fail if revision manager throws', async () => {
const useCase = createUseCase()
revisionManager.listRevisions = jest.fn().mockRejectedValue(new Error('error'))
const result = await useCase.execute({ itemUuid: '00000000-0000-0000-0000-000000000000' })
expect(result.isFailed()).toBe(true)
expect(result.getError()).toEqual('Could not list item revisions: error')
})
})

View File

@@ -15,8 +15,12 @@ export class ListRevisions implements UseCaseInterface<Array<RevisionMetadata>>
}
const itemUuid = itemUuidOrError.getValue()
const revisions = await this.revisionManager.listRevisions(itemUuid)
try {
const revisions = await this.revisionManager.listRevisions(itemUuid)
return Result.ok(revisions)
return Result.ok(revisions)
} catch (error) {
return Result.fail(`Could not list item revisions: ${(error as Error).message}`)
}
}
}