fix: don't render editor view on mobile if editor pane not selected (#1790)

This commit is contained in:
Aman Harwara
2022-10-14 18:33:43 +05:30
committed by GitHub
parent 0dad616c5c
commit d0c413cd15
3 changed files with 44 additions and 3 deletions

View File

@@ -1,19 +1,39 @@
import { AppPaneId } from './../Components/ResponsivePane/AppPaneMetadata'
import { isMobileScreen } from '@/Utils'
import { makeObservable, observable, action } from 'mobx'
import { Disposer } from '@/Types/Disposer'
import { MediaQueryBreakpoints } from '@/Hooks/useMediaQuery'
export class PaneController {
currentPane: AppPaneId = isMobileScreen() ? AppPaneId.Items : AppPaneId.Editor
previousPane: AppPaneId = isMobileScreen() ? AppPaneId.Items : AppPaneId.Editor
isInMobileView = isMobileScreen()
protected disposers: Disposer[] = []
constructor() {
makeObservable(this, {
currentPane: observable,
previousPane: observable,
isInMobileView: observable,
setCurrentPane: action,
setPreviousPane: action,
setIsInMobileView: action,
})
window.matchMedia(MediaQueryBreakpoints.md).addEventListener('change', this.mediumScreenMQHandler)
}
deinit() {
window.matchMedia(MediaQueryBreakpoints.md).removeEventListener('change', this.mediumScreenMQHandler)
}
mediumScreenMQHandler = (event: MediaQueryListEvent) => {
if (event.matches) {
this.isInMobileView = false
} else {
this.isInMobileView = true
}
}
setCurrentPane(pane: AppPaneId): void {
@@ -23,4 +43,8 @@ export class PaneController {
setPreviousPane(pane: AppPaneId): void {
this.previousPane = pane
}
setIsInMobileView(isInMobileView: boolean) {
this.isInMobileView = isInMobileView
}
}

View File

@@ -211,6 +211,8 @@ export class ViewControllerManager {
this.historyModalController.deinit()
;(this.historyModalController as unknown) = undefined
this.paneController.deinit()
;(this.paneController as unknown) = undefined
destroyAllObjectProperties(this)