diff --git a/packages/web/src/javascripts/Components/ChallengeModal/ChallengeModal.tsx b/packages/web/src/javascripts/Components/ChallengeModal/ChallengeModal.tsx index 1845f0e2e..033a8eddc 100644 --- a/packages/web/src/javascripts/Components/ChallengeModal/ChallengeModal.tsx +++ b/packages/web/src/javascripts/Components/ChallengeModal/ChallengeModal.tsx @@ -237,7 +237,7 @@ const ChallengeModal: FunctionComponent = ({ }) return ( - + = ({ ) })} - + {note && ( = ({ /> )} - + {note && pendingConversionItem && ( ))} - + {confirmationQueue[0] && ( - + - + diff --git a/packages/web/src/javascripts/Components/EditorWidthSelectionModal/EditorWidthSelectionModal.tsx b/packages/web/src/javascripts/Components/EditorWidthSelectionModal/EditorWidthSelectionModal.tsx index 32eecfebc..1423f9e87 100644 --- a/packages/web/src/javascripts/Components/EditorWidthSelectionModal/EditorWidthSelectionModal.tsx +++ b/packages/web/src/javascripts/Components/EditorWidthSelectionModal/EditorWidthSelectionModal.tsx @@ -8,7 +8,7 @@ import RadioButtonGroup from '../RadioButtonGroup/RadioButtonGroup' import { EditorMargins, EditorMaxWidths } from './EditorWidths' import { useApplication } from '../ApplicationProvider' import ModalOverlay from '../Modal/ModalOverlay' -import { CHANGE_EDITOR_WIDTH_COMMAND, ESCAPE_COMMAND } from '@standardnotes/ui-services' +import { CHANGE_EDITOR_WIDTH_COMMAND } from '@standardnotes/ui-services' import { PrefDefaults } from '@/Constants/PrefDefaults' import { observer } from 'mobx-react-lite' import Switch from '../Switch/Switch' @@ -37,7 +37,6 @@ const EditorWidthSelectionModal = ({ close: () => void note: SNNote | undefined }) => { - const application = useApplication() const isMobileScreen = useMediaQuery(MutuallyExclusiveMediaQueryBreakpoints.sm) const [value, setValue] = useState(() => initialValue) @@ -88,16 +87,6 @@ const EditorWidthSelectionModal = ({ [accept, close], ) - useEffect(() => { - return application.keyboardService.addCommandHandler({ - command: ESCAPE_COMMAND, - onKeyDown() { - close() - return true - }, - }) - }, [application.keyboardService, close]) - const DynamicMargin = (
@@ -207,7 +196,7 @@ const EditorWidthSelectionModalWrapper = () => { }, [application, toggle]) return ( - + ) diff --git a/packages/web/src/javascripts/Components/FilePreview/FilePreviewModal.tsx b/packages/web/src/javascripts/Components/FilePreview/FilePreviewModal.tsx index dcb4290e2..c8a547b44 100644 --- a/packages/web/src/javascripts/Components/FilePreview/FilePreviewModal.tsx +++ b/packages/web/src/javascripts/Components/FilePreview/FilePreviewModal.tsx @@ -285,7 +285,11 @@ FilePreviewModal.displayName = 'FilePreviewModal' const FilePreviewModalWrapper: FunctionComponent = ({ application, viewControllerManager }) => { return ( - + ) diff --git a/packages/web/src/javascripts/Components/ImportModal/ImportModal.tsx b/packages/web/src/javascripts/Components/ImportModal/ImportModal.tsx index ecc7cfbb1..879d6f379 100644 --- a/packages/web/src/javascripts/Components/ImportModal/ImportModal.tsx +++ b/packages/web/src/javascripts/Components/ImportModal/ImportModal.tsx @@ -33,7 +33,7 @@ const ImportModal = ({ importModalController }: { importModalController: ImportM ) return ( - +
{!files.length && } diff --git a/packages/web/src/javascripts/Components/Modal/ModalOverlay.tsx b/packages/web/src/javascripts/Components/Modal/ModalOverlay.tsx index 2fce8cc9b..4d5f58a4a 100644 --- a/packages/web/src/javascripts/Components/Modal/ModalOverlay.tsx +++ b/packages/web/src/javascripts/Components/Modal/ModalOverlay.tsx @@ -7,13 +7,19 @@ type Props = { isOpen: boolean children: ReactNode animationVariant?: 'horizontal' | 'vertical' + close: () => void } const ModalOverlay = forwardRef( - ({ isOpen, children, animationVariant, ...props }: Props, ref: ForwardedRef) => { + ({ isOpen, children, animationVariant, close, ...props }: Props, ref: ForwardedRef) => { const [isMounted, setElement] = useModalAnimation(isOpen, animationVariant) const dialog = useDialogStore({ open: isMounted, + setOpen: (open) => { + if (!open) { + close() + } + }, }) if (!isMounted) { diff --git a/packages/web/src/javascripts/Components/NotesOptions/NotesOptions.tsx b/packages/web/src/javascripts/Components/NotesOptions/NotesOptions.tsx index ce7023db8..c0d030ea9 100644 --- a/packages/web/src/javascripts/Components/NotesOptions/NotesOptions.tsx +++ b/packages/web/src/javascripts/Components/NotesOptions/NotesOptions.tsx @@ -413,7 +413,7 @@ const NotesOptions = ({ ) : null} - + diff --git a/packages/web/src/javascripts/Components/PermissionsModal/PermissionsModalWrapper.tsx b/packages/web/src/javascripts/Components/PermissionsModal/PermissionsModalWrapper.tsx index d0213fa57..3b4292167 100644 --- a/packages/web/src/javascripts/Components/PermissionsModal/PermissionsModalWrapper.tsx +++ b/packages/web/src/javascripts/Components/PermissionsModal/PermissionsModalWrapper.tsx @@ -44,7 +44,7 @@ const PermissionsModalWrapper: FunctionComponent = ({ application }) => { }, [application, onAppStart]) return ( - + {dialog && ( = ({ application }: Props) => { Current password was set on {passwordCreatedOn}