From e040291b116847011f2d88d7a93320eac2c0ed5a Mon Sep 17 00:00:00 2001
From: Aman Harwara <amanharwara@protonmail.com>
Date: Fri, 1 Dec 2023 18:18:22 +0530
Subject: [PATCH] refactor: import modal (#2670)

---
 .../Components/ImportModal/ImportModal.tsx    | 52 +++++++---
 .../ImportModal/ImportModalController.ts      | 15 ++-
 .../ImportModal/ImportModalFileItem.tsx       | 97 ++++++++++++-------
 .../Components/ImportModal/InitialPage.tsx    | 18 +---
 4 files changed, 119 insertions(+), 63 deletions(-)

diff --git a/packages/web/src/javascripts/Components/ImportModal/ImportModal.tsx b/packages/web/src/javascripts/Components/ImportModal/ImportModal.tsx
index ea588faf7..1ddf6e8e6 100644
--- a/packages/web/src/javascripts/Components/ImportModal/ImportModal.tsx
+++ b/packages/web/src/javascripts/Components/ImportModal/ImportModal.tsx
@@ -1,5 +1,5 @@
 import { observer } from 'mobx-react-lite'
-import { useMemo } from 'react'
+import { useCallback, useMemo } from 'react'
 import ImportModalFileItem from './ImportModalFileItem'
 import ImportModalInitialPage from './InitialPage'
 import Modal, { ModalAction } from '../Modal/Modal'
@@ -11,6 +11,9 @@ import LinkedItemBubble from '../LinkedItems/LinkedItemBubble'
 import { createLinkFromItem } from '@/Utils/Items/Search/createLinkFromItem'
 import ItemSelectionDropdown from '../ItemSelectionDropdown/ItemSelectionDropdown'
 import { ContentType, SNTag } from '@standardnotes/snjs'
+import Button from '../Button/Button'
+import { ClassicFileReader } from '@standardnotes/filepicker'
+import { NoteImportType } from '@standardnotes/ui-services'
 
 const ImportModal = ({ importModalController }: { importModalController: ImportModalController }) => {
   const application = useApplication()
@@ -18,6 +21,7 @@ const ImportModal = ({ importModalController }: { importModalController: ImportM
   const {
     files,
     setFiles,
+    addFiles,
     addImportsToTag,
     setAddImportsToTag,
     shouldCreateTag,
@@ -55,23 +59,45 @@ const ImportModal = ({ importModalController }: { importModalController: ImportM
     [close, existingTagForImports, importSuccessOrError, isReadyToImport, parseAndImport, shouldCreateTag],
   )
 
+  const selectFiles = useCallback(
+    async (service?: NoteImportType) => {
+      const files = await ClassicFileReader.selectFiles()
+
+      addFiles(files, service)
+    },
+    [addFiles],
+  )
+
   return (
     <ModalOverlay isOpen={isVisible} close={close}>
       <Modal title="Import" close={close} actions={modalActions} className="flex flex-col">
         <div className="min-h-0 flex-grow px-4 py-4">
-          {!files.length && <ImportModalInitialPage setFiles={setFiles} />}
+          {!files.length && <ImportModalInitialPage setFiles={setFiles} selectFiles={selectFiles} />}
           {files.length > 0 && (
-            <div className="divide-y divide-border">
-              {files.map((file) => (
-                <ImportModalFileItem
-                  file={file}
-                  key={file.id}
-                  updateFile={updateFile}
-                  removeFile={removeFile}
-                  importer={application.importer}
-                />
-              ))}
-            </div>
+            <>
+              <div className="divide-y divide-border">
+                {files.map((file) => (
+                  <ImportModalFileItem
+                    file={file}
+                    key={file.id}
+                    updateFile={updateFile}
+                    removeFile={removeFile}
+                    importer={application.importer}
+                  />
+                ))}
+              </div>
+              {!importSuccessOrError && (
+                <Button
+                  className="mt-4"
+                  onClick={() => {
+                    selectFiles().catch(console.error)
+                  }}
+                  small
+                >
+                  Add files
+                </Button>
+              )}
+            </>
           )}
         </div>
         {files.length > 0 && (
diff --git a/packages/web/src/javascripts/Components/ImportModal/ImportModalController.ts b/packages/web/src/javascripts/Components/ImportModal/ImportModalController.ts
index ba3f5b7a2..2c084d2a0 100644
--- a/packages/web/src/javascripts/Components/ImportModal/ImportModalController.ts
+++ b/packages/web/src/javascripts/Components/ImportModal/ImportModalController.ts
@@ -66,6 +66,7 @@ export class ImportModalController extends AbstractViewController {
 
       files: observable,
       setFiles: action,
+      addFiles: action,
       updateFile: action,
       removeFile: action,
 
@@ -106,13 +107,21 @@ export class ImportModalController extends AbstractViewController {
     this.preferences.setValue(PrefKey.ExistingTagForImports, tag?.uuid).catch(console.error)
   }
 
-  setFiles = (files: File[], service?: NoteImportType) => {
-    this.files = files.map((file) => ({
+  getImportFromFile = (file: File, service?: NoteImportType) => {
+    return {
       id: UuidGenerator.GenerateUuid(),
       file,
       service,
       status: service ? 'ready' : 'pending',
-    }))
+    } as ImportModalFile
+  }
+
+  setFiles = (files: File[], service?: NoteImportType) => {
+    this.files = files.map((file) => this.getImportFromFile(file, service))
+  }
+
+  addFiles = (files: File[], service?: NoteImportType) => {
+    this.files = [...this.files, ...files.map((file) => this.getImportFromFile(file, service))]
   }
 
   updateFile = (file: ImportModalFile) => {
diff --git a/packages/web/src/javascripts/Components/ImportModal/ImportModalFileItem.tsx b/packages/web/src/javascripts/Components/ImportModal/ImportModalFileItem.tsx
index 7cac899d7..13e810054 100644
--- a/packages/web/src/javascripts/Components/ImportModal/ImportModalFileItem.tsx
+++ b/packages/web/src/javascripts/Components/ImportModal/ImportModalFileItem.tsx
@@ -1,8 +1,8 @@
 import { ImportModalController, ImportModalFile } from '@/Components/ImportModal/ImportModalController'
-import { classNames, ContentType, DecryptedTransferPayload, pluralize } from '@standardnotes/snjs'
+import { classNames, ContentType, pluralize } from '@standardnotes/snjs'
 import { Importer, NoteImportType } from '@standardnotes/ui-services'
 import { observer } from 'mobx-react-lite'
-import { useCallback, useEffect } from 'react'
+import { useCallback, useEffect, useState } from 'react'
 import Icon from '../Icon/Icon'
 
 const NoteImportTypeColors: Record<NoteImportType, string> = {
@@ -36,23 +36,20 @@ const ImportModalFileItem = ({
   removeFile: ImportModalController['removeFile']
   importer: Importer
 }) => {
+  const [changingService, setChangingService] = useState(false)
+
   const setFileService = useCallback(
     async (service: NoteImportType | null) => {
-      let payloads: DecryptedTransferPayload[] | undefined
-      try {
-        payloads = service ? await importer.getPayloadsFromFile(file.file, service) : undefined
-      } catch (error) {
-        console.error(error)
+      if (!service) {
+        setChangingService(true)
       }
-
       updateFile({
         ...file,
         service,
         status: service ? 'ready' : 'pending',
-        payloads,
       })
     },
-    [file, importer, updateFile],
+    [file, updateFile],
   )
 
   useEffect(() => {
@@ -82,7 +79,7 @@ const ImportModalFileItem = ({
   return (
     <div
       className={classNames(
-        'flex gap-2 px-2 py-2',
+        'flex gap-2 px-2 py-2.5',
         file.service == null ? 'flex-col items-start md:flex-row md:items-center' : 'items-center',
       )}
     >
@@ -100,7 +97,7 @@ const ImportModalFileItem = ({
                 ? payloadsImportMessage
                 : 'Ready to import'
               : null}
-            {file.status === 'pending' && 'Could not auto-detect service. Please select manually.'}
+            {file.status === 'pending' && !file.service && 'Could not auto-detect service. Please select manually.'}
             {file.status === 'parsing' && 'Parsing...'}
             {file.status === 'importing' && 'Importing...'}
             {file.status === 'uploading-files' && 'Uploading and embedding files...'}
@@ -109,35 +106,69 @@ const ImportModalFileItem = ({
           </div>
         </div>
       </div>
-      {file.service == null && (
+      {(file.status === 'ready' || file.status === 'pending') && (
         <div className="flex items-center">
-          <form
-            className="flex items-center"
-            onSubmit={(event) => {
-              event.preventDefault()
-              const form = event.target as HTMLFormElement
-              const service = form.elements[0] as HTMLSelectElement
-              void setFileService(service.value as NoteImportType)
-            }}
-          >
-            <select className="mr-2 rounded border border-border bg-default px-2 py-1 text-sm">
-              <option value="evernote">Evernote</option>
-              <option value="simplenote">Simplenote</option>
-              <option value="google-keep">Google Keep</option>
-              <option value="aegis">Aegis</option>
-              <option value="plaintext">Plaintext</option>
-            </select>
-            <button type="submit" className="rounded border border-border bg-default p-1.5 hover:bg-contrast">
-              <Icon type="check" size="medium" />
+          {changingService ? (
+            <>
+              <form
+                className="flex items-center"
+                onSubmit={(event) => {
+                  event.preventDefault()
+                  const form = event.target as HTMLFormElement
+                  const service = form.elements[0] as HTMLSelectElement
+                  void setFileService(service.value as NoteImportType)
+                  setChangingService(false)
+                }}
+              >
+                <select
+                  className="mr-2 rounded border border-border bg-default px-2 py-1 text-sm"
+                  defaultValue={file.service ? file.service : undefined}
+                >
+                  <option value="evernote">Evernote</option>
+                  <option value="simplenote">Simplenote</option>
+                  <option value="google-keep">Google Keep</option>
+                  <option value="aegis">Aegis</option>
+                  <option value="plaintext">Plaintext</option>
+                  <option value="html">HTML</option>
+                  <option value="super">Super</option>
+                </select>
+                <button
+                  aria-label="Choose service"
+                  type="submit"
+                  className="rounded border border-border bg-default p-1.5 hover:bg-contrast"
+                >
+                  <Icon type="check" size="medium" />
+                </button>
+              </form>
+              <button
+                aria-label="Cancel"
+                className="ml-2 rounded border border-border bg-default p-1.5 hover:bg-contrast"
+                onClick={() => {
+                  setChangingService(false)
+                }}
+              >
+                <Icon type="close" size="medium" />
+              </button>
+            </>
+          ) : (
+            <button
+              aria-label="Change service"
+              className="rounded border border-border bg-default p-1.5 hover:bg-contrast"
+              onClick={() => {
+                setChangingService(true)
+              }}
+            >
+              <Icon type="settings" size="medium" />
             </button>
-          </form>
+          )}
           <button
+            aria-label="Remove"
             className="ml-2 rounded border border-border bg-default p-1.5 hover:bg-contrast"
             onClick={() => {
               removeFile(file.id)
             }}
           >
-            <Icon type="close" size="medium" />
+            <Icon type="trash" size="medium" />
           </button>
         </div>
       )}
diff --git a/packages/web/src/javascripts/Components/ImportModal/InitialPage.tsx b/packages/web/src/javascripts/Components/ImportModal/InitialPage.tsx
index 7f44415ec..fa32d483e 100644
--- a/packages/web/src/javascripts/Components/ImportModal/InitialPage.tsx
+++ b/packages/web/src/javascripts/Components/ImportModal/InitialPage.tsx
@@ -1,30 +1,20 @@
 import { ImportModalController } from '@/Components/ImportModal/ImportModalController'
-import { ClassicFileReader } from '@standardnotes/filepicker'
-import { NoteImportType } from '@standardnotes/ui-services'
 import { observer } from 'mobx-react-lite'
-import { useCallback } from 'react'
 import Button from '../Button/Button'
 import Icon from '../Icon/Icon'
 import { useApplication } from '../ApplicationProvider'
-import { FeatureStatus, NativeFeatureIdentifier } from '@standardnotes/snjs'
 import { FeatureName } from '@/Controllers/FeatureName'
+import { NativeFeatureIdentifier, FeatureStatus } from '@standardnotes/snjs'
+import { NoteImportType } from '@standardnotes/ui-services'
 
 type Props = {
   setFiles: ImportModalController['setFiles']
+  selectFiles: (service?: NoteImportType) => Promise<void>
 }
 
-const ImportModalInitialPage = ({ setFiles }: Props) => {
+const ImportModalInitialPage = ({ setFiles, selectFiles }: Props) => {
   const application = useApplication()
 
-  const selectFiles = useCallback(
-    async (service?: NoteImportType) => {
-      const files = await ClassicFileReader.selectFiles()
-
-      setFiles(files, service)
-    },
-    [setFiles],
-  )
-
   return (
     <>
       <button