From e2ee69ba6f3d6305380f69fdba4af70f090d1672 Mon Sep 17 00:00:00 2001 From: Mo Bitar Date: Sat, 28 Apr 2018 11:14:34 -0500 Subject: [PATCH] Remove footer component active persistence, so that if a modal or the Extensions window is opened on one computer, it doesn't open on another computer. The inspiration for this was since opening and closing the Ext window no longer syncs the .active state of that window, if the Extensions ext is for whatever reason synced while it was open, setting .active to true, then, it's impossible to reset that flag. So it will perpetually open and nothing cna be done about it. --- app/assets/javascripts/app/controllers/footer.js | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/app/assets/javascripts/app/controllers/footer.js b/app/assets/javascripts/app/controllers/footer.js index bb60eb9ec..5ecce3c75 100644 --- a/app/assets/javascripts/app/controllers/footer.js +++ b/app/assets/javascripts/app/controllers/footer.js @@ -129,18 +129,9 @@ angular.module('app') }); componentManager.registerHandler({identifier: "roomBar", areas: ["rooms", "modal"], activationHandler: (component) => { - if(component.active) { - // Show room, if it was not activated manually (in the event of event from componentManager) - if(component.area == "rooms" && !component.showRoom) { - component.showRoom = true; - } - $timeout(() => { - var lastSize = component.getLastSize(); - if(lastSize) { - componentManager.handleSetSizeEvent(component, lastSize); - } - }); - } + // RIP: There used to be code here that checked if component.active was true, and if so, displayed the component. + // However, we no longer want to persist active state for footer extensions. If you open Extensions on one computer, + // it shouldn't open on another computer. Active state should only be persisted for persistent extensions, like Folders. }, actionHandler: (component, action, data) => { if(action == "set-size") { component.setLastSize(data);