rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: improve deinit logic and flow

Browse Source
This commit is contained in:
Mo
2022-02-08 21:35:31 -06:00
parent 1dd70364e7
commit e43c8a6f07
6 changed files with 82 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
app/assets/javascripts/ui_models/app_state/app_state.ts
View File

@@ -93,7 +93,6 @@ export class AppState {
private readonly tagChangedDisposer: IReactionDisposer;
/* @ngInject */
constructor(application: WebApplication, private bridge: Bridge) {
this.application = application;
this.notes = new NotesState(
@@ -171,18 +170,39 @@ export class AppState {
storage.remove(StorageKey.ShowBetaWarning);
this.noAccountWarning.reset();
}
(this.application as unknown) = undefined;
this.actionsMenu.reset();
this.unsubApp?.();
this.unsubApp = undefined;
this.observers.length = 0;
this.appEventObserverRemovers.forEach((remover) => remover());
this.features.deinit();
this.appEventObserverRemovers.length = 0;
this.features.deinit();
(this.features as unknown) = undefined;
this.webAppEventDisposer?.();
this.webAppEventDisposer = undefined;
(this.quickSettingsMenu as unknown) = undefined;
(this.accountMenu as unknown) = undefined;
(this.actionsMenu as unknown) = undefined;
(this.preferences as unknown) = undefined;
(this.purchaseFlow as unknown) = undefined;
(this.noteTags as unknown) = undefined;
(this.sync as unknown) = undefined;
(this.searchOptions as unknown) = undefined;
(this.notes as unknown) = undefined;
(this.features as unknown) = undefined;
(this.tags as unknown) = undefined;
(this.notesView as unknown) = undefined;
document.removeEventListener('visibilitychange', this.onVisibilityChange);
this.onVisibilityChange = undefined;
this.tagChangedDisposer();
(this.tagChangedDisposer as unknown) = undefined;
}
openSessionsModal(): void {