refactor: improve setState semantics

2020-07-07 11:55:04 +02:00
parent 15039bd16c
commit e45d28b07a
1 changed files with 3 additions and 5 deletions
--- a/app/assets/javascripts/views/abstract/pure_view_ctrl.ts
+++ b/app/assets/javascripts/views/abstract/pure_view_ctrl.ts
@@ -59,15 +59,13 @@ export class PureViewCtrl<P = CtrlProps, S = CtrlState> {
    return {} as any;
  }

-  async setState(state: CtrlState) {
+  async setState(state: Partial<S>) {
    if (!this.$timeout) {
      return;
    }
+    this.state = Object.freeze(Object.assign({}, this.state, state));
    return new Promise((resolve) => {
-      this.stateTimeout = this.$timeout(() => {
-        this.state = Object.freeze(Object.assign({}, this.state, state));
-        resolve();
-      });
+      this.stateTimeout = this.$timeout(resolve);
    });
  }