From eb5e5e11e0c16eee5dbbde18a84602e60f0d0c5e Mon Sep 17 00:00:00 2001 From: Aman Harwara Date: Fri, 22 Mar 2024 19:19:23 +0530 Subject: [PATCH] chore: fix dark mode keyboard shortcut [skip e2e] --- .../javascripts/Components/Footer/QuickSettingsButton.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/web/src/javascripts/Components/Footer/QuickSettingsButton.tsx b/packages/web/src/javascripts/Components/Footer/QuickSettingsButton.tsx index 10c857f40..13cc02b61 100644 --- a/packages/web/src/javascripts/Components/Footer/QuickSettingsButton.tsx +++ b/packages/web/src/javascripts/Components/Footer/QuickSettingsButton.tsx @@ -23,12 +23,15 @@ const QuickSettingsButton = ({ application, isMobileNavigation = false }: Props) const toggleMenu = () => setIsOpen(!isOpen) useEffect(() => { + const darkThemeFeature = new UIFeature(GetDarkThemeFeature()) + return commandService.addCommandHandler({ command: TOGGLE_DARK_MODE_COMMAND, category: 'General', description: 'Toggle dark mode', onKeyDown: () => { - void application.componentManager.toggleTheme(new UIFeature(GetDarkThemeFeature())) + void application.componentManager.toggleTheme(darkThemeFeature) + return true }, }) }, [application, commandService])