ApplicationManager and better memory management

2020-03-23 19:59:55 -05:00
parent 7dc3dab90b
commit ee7cb1fce6
55 changed files with 36786 additions and 3046 deletions
--- a/app/assets/javascripts/directives/views/componentModal.js
+++ b/app/assets/javascripts/directives/views/componentModal.js
@@ -2,18 +2,19 @@ import template from '%/directives/component-modal.pug';

 export class ComponentModalCtrl {
  /* @ngInject */
-  constructor($scope, $element) {
+  constructor($element) {
    this.$element = $element;
-    this.$scope = $scope;
  }

  dismiss(callback) {
-    this.$element.remove();
-    this.$scope.$destroy();
-    if(this.onDismiss && this.onDismiss()) {
-      this.onDismiss()(this.component);
+    if(this.onDismiss) {
+      this.onDismiss(this.component);
    }
-    callback && callback();
+    this.callback && this.callback();
+    const elem = this.$element;
+    const scope = elem.scope();
+    scope.$destroy();
+    elem.remove();
  }
 }