ApplicationManager and better memory management

2020-03-23 19:59:55 -05:00
parent 7dc3dab90b
commit ee7cb1fce6
55 changed files with 36786 additions and 3046 deletions
--- a/app/assets/javascripts/directives/views/privilegesAuthModal.js
+++ b/app/assets/javascripts/directives/views/privilegesAuthModal.js
@@ -4,12 +4,10 @@ class PrivilegesAuthModalCtrl {
  /* @ngInject */
  constructor(
    $element,
-    $timeout,
-    application
+    $timeout
  ) {
    this.$element = $element;
    this.$timeout = $timeout;
-    this.application = application;
  }

  $onInit() {
@@ -83,7 +81,10 @@ class PrivilegesAuthModalCtrl {
  }

  dismiss() {
-    this.$element.remove();
+    const elem = this.$element;
+    const scope = elem.scope();
+    scope.$destroy();
+    elem.remove();
  }
 }

@@ -97,7 +98,8 @@ export class PrivilegesAuthModal {
    this.scope = {
      action: '=',
      onSuccess: '=',
-      onCancel: '='
+      onCancel: '=',
+      application: '='
    };
  }
 }