From f3a97178830b174f971af6dd4cc739cc79118a1e Mon Sep 17 00:00:00 2001
From: Aman Harwara <amanharwara@protonmail.com>
Date: Sun, 29 Oct 2023 14:41:37 +0530
Subject: [PATCH] chore: fix tag options menu opening notes list [skip e2e]

---
 .../src/javascripts/Components/Tags/SmartViewsListItem.tsx  | 2 +-
 packages/web/src/javascripts/Components/Tags/TagsList.tsx   | 4 +++-
 .../web/src/javascripts/Components/Tags/TagsListItem.tsx    | 6 +++++-
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/packages/web/src/javascripts/Components/Tags/SmartViewsListItem.tsx b/packages/web/src/javascripts/Components/Tags/SmartViewsListItem.tsx
index 8e0ee411b..1a98f0d4f 100644
--- a/packages/web/src/javascripts/Components/Tags/SmartViewsListItem.tsx
+++ b/packages/web/src/javascripts/Components/Tags/SmartViewsListItem.tsx
@@ -115,7 +115,7 @@ const SmartViewsListItem: FunctionComponent<Props> = ({ view, tagsState, setEdit
       <div
         role="button"
         tabIndex={FOCUSABLE_BUT_NOT_TABBABLE}
-        className={classNames('tag group px-3.5', isSelected && 'selected', isFaded && 'opacity-50')}
+        className={classNames('tag group px-3.5 py-1 md:py-0', isSelected && 'selected', isFaded && 'opacity-50')}
         onClick={selectCurrentTag}
         onContextMenu={(event) => {
           event.preventDefault()
diff --git a/packages/web/src/javascripts/Components/Tags/TagsList.tsx b/packages/web/src/javascripts/Components/Tags/TagsList.tsx
index 7b4062199..a1b176dd4 100644
--- a/packages/web/src/javascripts/Components/Tags/TagsList.tsx
+++ b/packages/web/src/javascripts/Components/Tags/TagsList.tsx
@@ -30,7 +30,9 @@ const TagsList: FunctionComponent<Props> = ({ type }: Props) => {
 
   const onContextMenu = useCallback(
     (tag: SNTag, posX: number, posY: number) => {
-      void application.navigationController.setSelectedTag(tag, type)
+      if (application.navigationController.selected !== tag) {
+        void application.navigationController.setSelectedTag(tag, type)
+      }
       openTagContextMenu(posX, posY)
     },
     [application, openTagContextMenu, type],
diff --git a/packages/web/src/javascripts/Components/Tags/TagsListItem.tsx b/packages/web/src/javascripts/Components/Tags/TagsListItem.tsx
index f1c596ac6..34338dce9 100644
--- a/packages/web/src/javascripts/Components/Tags/TagsListItem.tsx
+++ b/packages/web/src/javascripts/Components/Tags/TagsListItem.tsx
@@ -260,7 +260,11 @@ export const TagsListItem: FunctionComponent<Props> = observer(
         <div
           role="button"
           tabIndex={FOCUSABLE_BUT_NOT_TABBABLE}
-          className={classNames('tag group px-3.5', isSelected && 'selected', isBeingDraggedOver && 'is-drag-over')}
+          className={classNames(
+            'tag group px-3.5 py-1 md:py-0',
+            isSelected && 'selected',
+            isBeingDraggedOver && 'is-drag-over',
+          )}
           onClick={selectCurrentTag}
           ref={tagRef}
           style={{