replace includes with lodash

This commit is contained in:
Mo Bitar
2017-01-15 20:32:43 -06:00
parent bbedad0fc5
commit fbbfccdfe6
2 changed files with 5 additions and 5 deletions

View File

@@ -13,7 +13,7 @@ class ExtensionManager {
ext.encrypted = this.extensionUsesEncryptedData(ext); ext.encrypted = this.extensionUsesEncryptedData(ext);
for (var action of ext.actions) { for (var action of ext.actions) {
if(this.enabledRepeatActionUrls.includes(action.url)) { if(_.includes(this.enabledRepeatActionUrls, action.url)) {
this.enableRepeatAction(action, ext); this.enableRepeatAction(action, ext);
} }
} }
@@ -38,7 +38,7 @@ class ExtensionManager {
} }
extensionUsesEncryptedData(extension) { extensionUsesEncryptedData(extension) {
return !this.decryptedExtensions.includes(extension.url); return !_.includes(this.decryptedExtensions, extension.url);
} }
changeExtensionEncryptionFormat(encrypted, extension) { changeExtensionEncryptionFormat(encrypted, extension) {
@@ -174,7 +174,7 @@ class ExtensionManager {
} }
isRepeatActionEnabled(action) { isRepeatActionEnabled(action) {
return this.enabledRepeatActionUrls.includes(action.url); return _.includes(this.enabledRepeatActionUrls, action.url);
} }
disableRepeatAction(action, extension) { disableRepeatAction(action, extension) {

View File

@@ -24,7 +24,7 @@ class ModelManager {
allItemsMatchingTypes(contentTypes) { allItemsMatchingTypes(contentTypes) {
return this.items.filter(function(item){ return this.items.filter(function(item){
return (contentTypes.includes(item.content_type) || contentTypes.includes("*")) && !item.dummy; return (_.includes(contentTypes, item.content_type) || _.includes(contentTypes, "*")) && !item.dummy;
}) })
} }
@@ -83,7 +83,7 @@ class ModelManager {
notifyItemChangeObserversOfModels(models) { notifyItemChangeObserversOfModels(models) {
for(var observer of this.itemChangeObservers) { for(var observer of this.itemChangeObservers) {
var relevantItems = models.filter(function(item){ var relevantItems = models.filter(function(item){
return observer.content_types.includes(item.content_type) || observer.content_types.includes("*"); return _.includes(observer.content_types, item.content_type) || _.includes(observer.content_types, "*");
}); });
if(relevantItems.length > 0) { if(relevantItems.length > 0) {