From febaf5185d09035fd067d00e395441c11fc5a441 Mon Sep 17 00:00:00 2001 From: Aman Harwara Date: Thu, 21 Sep 2023 21:46:46 +0530 Subject: [PATCH] chore: when creating new tag from link input, move it to the vault the item is in before linking --- .../javascripts/Controllers/LinkingController.tsx | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/packages/web/src/javascripts/Controllers/LinkingController.tsx b/packages/web/src/javascripts/Controllers/LinkingController.tsx index 7eba1d9d7..d61358590 100644 --- a/packages/web/src/javascripts/Controllers/LinkingController.tsx +++ b/packages/web/src/javascripts/Controllers/LinkingController.tsx @@ -302,7 +302,17 @@ export class LinkingController extends AbstractViewController implements Interna const activeItem = this.activeItem if (activeItem) { - await this.addTagToItem(newTag, activeItem) + const itemVault = this.vaults.getItemVault(activeItem) + + if (itemVault) { + const movedTag = await this.vaults.moveItemToVault(itemVault, newTag) + if (!movedTag) { + throw new Error('Failed to move tag to item vault') + } + await this.addTagToItem(movedTag as SNTag, activeItem) + } else { + await this.addTagToItem(newTag, activeItem) + } } return newTag