chore: remove sync call causing tests to become flaky

packages/services/src/Domain/SharedVaults/SharedVaultService.spec.ts

@@ -49,7 +49,6 @@ describe('SharedVaultService', () => {
     eventBus.addEventHandler = jest.fn()
 
     service = new SharedVaultService(
-      sync,
       items,
       session,
       vaultUsers,

packages/services/src/Domain/SharedVaults/SharedVaultService.ts

@@ -34,14 +34,12 @@ import { FindContact } from '../Contacts/UseCase/FindContact'
 import { GetOwnedSharedVaults } from './UseCase/GetOwnedSharedVaults'
 import { SyncLocalVaultsWithRemoteSharedVaults } from './UseCase/SyncLocalVaultsWithRemoteSharedVaults'
 import { VaultUserServiceInterface } from '../VaultUser/VaultUserServiceInterface'
-import { SyncServiceInterface } from '../Sync/SyncServiceInterface'
 
 export class SharedVaultService
   extends AbstractService<SharedVaultServiceEvent, SharedVaultServiceEventPayload>
   implements SharedVaultServiceInterface, InternalEventHandlerInterface
 {
   constructor(
-    private sync: SyncServiceInterface,
     private items: ItemManagerInterface,
     private session: SessionsClientInterface,
     private vaultUsers: VaultUserServiceInterface,
@@ -125,13 +123,8 @@ export class SharedVaultService
             .invalidateVaultUsersCache(event.eventPayload.props.primaryIdentifier.value)
             .catch(console.error)
 
-          this.sync
-            .sync()
-            .then(async () => {
-              await this._syncLocalVaultsWithRemoteSharedVaults.execute([vault])
-              void this.notifyEvent(SharedVaultServiceEvent.SharedVaultStatusChanged)
-            })
-            .catch(console.error)
+          await this._syncLocalVaultsWithRemoteSharedVaults.execute([vault])
+          void this.notifyEvent(SharedVaultServiceEvent.SharedVaultStatusChanged)
         }
         break
       }

packages/snjs/lib/Application/Dependencies/Dependencies.ts

@@ -921,7 +921,6 @@ export class Dependencies {
 
     this.factory.set(TYPES.SharedVaultService, () => {
       return new SharedVaultService(
-        this.get<SyncService>(TYPES.SyncService),
         this.get<ItemManager>(TYPES.ItemManager),
         this.get<SessionManager>(TYPES.SessionManager),
         this.get<VaultUserService>(TYPES.VaultUserService),