rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: remove sync call causing tests to become flaky

Browse Source
This commit is contained in:
Aman Harwara
2023-10-02 19:15:58 +05:30
parent 78d9ad3c2a
commit fff4696fa2
3 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/services/src/Domain/SharedVaults/SharedVaultService.spec.ts
View File

@@ -49,7 +49,6 @@ describe('SharedVaultService', () => {
eventBus.addEventHandler = jest.fn() eventBus.addEventHandler = jest.fn()
service = new SharedVaultService( service = new SharedVaultService(
sync,
items, items,
session, session,
vaultUsers, vaultUsers,

7
packages/services/src/Domain/SharedVaults/SharedVaultService.ts
View File

@@ -34,14 +34,12 @@ import { FindContact } from '../Contacts/UseCase/FindContact'
import { GetOwnedSharedVaults } from './UseCase/GetOwnedSharedVaults' import { GetOwnedSharedVaults } from './UseCase/GetOwnedSharedVaults'
import { SyncLocalVaultsWithRemoteSharedVaults } from './UseCase/SyncLocalVaultsWithRemoteSharedVaults' import { SyncLocalVaultsWithRemoteSharedVaults } from './UseCase/SyncLocalVaultsWithRemoteSharedVaults'
import { VaultUserServiceInterface } from '../VaultUser/VaultUserServiceInterface' import { VaultUserServiceInterface } from '../VaultUser/VaultUserServiceInterface'
import { SyncServiceInterface } from '../Sync/SyncServiceInterface'
export class SharedVaultService export class SharedVaultService
extends AbstractService<SharedVaultServiceEvent, SharedVaultServiceEventPayload> extends AbstractService<SharedVaultServiceEvent, SharedVaultServiceEventPayload>
implements SharedVaultServiceInterface, InternalEventHandlerInterface implements SharedVaultServiceInterface, InternalEventHandlerInterface
{ {
constructor( constructor(
private sync: SyncServiceInterface,
private items: ItemManagerInterface, private items: ItemManagerInterface,
private session: SessionsClientInterface, private session: SessionsClientInterface,
private vaultUsers: VaultUserServiceInterface, private vaultUsers: VaultUserServiceInterface,
@@ -125,13 +123,8 @@ export class SharedVaultService
.invalidateVaultUsersCache(event.eventPayload.props.primaryIdentifier.value) .invalidateVaultUsersCache(event.eventPayload.props.primaryIdentifier.value)
.catch(console.error) .catch(console.error)
this.sync
.sync()
.then(async () => {
await this._syncLocalVaultsWithRemoteSharedVaults.execute([vault]) await this._syncLocalVaultsWithRemoteSharedVaults.execute([vault])
void this.notifyEvent(SharedVaultServiceEvent.SharedVaultStatusChanged) void this.notifyEvent(SharedVaultServiceEvent.SharedVaultStatusChanged)
})
.catch(console.error)
} }
break break
} }

1
packages/snjs/lib/Application/Dependencies/Dependencies.ts
View File

@@ -921,7 +921,6 @@ export class Dependencies {
this.factory.set(TYPES.SharedVaultService, () => { this.factory.set(TYPES.SharedVaultService, () => {
return new SharedVaultService( return new SharedVaultService(
this.get<SyncService>(TYPES.SyncService),
this.get<ItemManager>(TYPES.ItemManager), this.get<ItemManager>(TYPES.ItemManager),
this.get<SessionManager>(TYPES.SessionManager), this.get<SessionManager>(TYPES.SessionManager),
this.get<VaultUserService>(TYPES.VaultUserService), this.get<VaultUserService>(TYPES.VaultUserService),