rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Do not notify observers of invalid items

Browse Source
This commit is contained in:
Mo Bitar
2018-05-25 15:46:18 -05:00
parent 4771bef974
commit 1ce07ae597
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/app/services/componentManager.js
View File

@@ -371,7 +371,7 @@ class ComponentManager {
// push immediately now
var items = [];
for(var contentType of message.data.content_types) {
items = items.concat(this.modelManager.itemsForContentType(contentType));
items = items.concat(this.modelManager.validItemsForContentType(contentType));
}
this.sendItemsInReply(component, items, message);
});

12
app/assets/javascripts/app/services/modelManager.js
View File

@@ -102,9 +102,9 @@ class ModelManager {
})
}
itemsForContentType(contentType) {
return this.allItems.filter(function(item){
return item.content_type == contentType;
validItemsForContentType(contentType) {
return this.allItems.filter((item) => {
return item.content_type == contentType && !item.errorDecrypting;
});
}
@@ -185,7 +185,11 @@ class ModelManager {
this.addItem(item, isDirtyItemPendingDelete);
modelsToNotifyObserversOf.push(item);
// Observers do not need to handle items that errored while decrypting.
if(!item.errorDecrypting) {
modelsToNotifyObserversOf.push(item);
}
models.push(item);
processedObjects.push(json_obj);
}