chore: fix eslint crashing issues (#1951)

packages/desktop/.eslintignore

@@ -1,3 +0,0 @@
-node_modules
-dist
-jsign

packages/desktop/.eslintrc

@@ -1,16 +0,0 @@
-{
-  "env": {
-    "node": true,
-    "commonjs": true
-  },
-  "extends": ["../../.eslintrc.json"],
-  "rules": {
-    "no-console": "off",
-    "@typescript-eslint/no-explicit-any": "warn",
-    "@typescript-eslint/no-var-requires": "off"
-  },
-  "globals": {
-    "zip": true
-  },
-  "ignorePatterns": ["scripts"]
-}

packages/desktop/.eslintrc.js

@@ -0,0 +1,16 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts', '@types', 'node_modules', 'dist'],
+  rules: {
+    'no-console': ['warn', { allow: ['warn', 'error'] }],
+    '@typescript-eslint/no-var-requires': 'off',
+  },
+  globals: {
+    zip: true,
+  },
+}

packages/desktop/app/javascripts/Renderer/Renderer.ts

@@ -41,7 +41,7 @@ const loadAndStartApplication = async () => {
 
   window.device = await createDesktopDevice(remoteBridge)
 
-  window.startApplication(DEFAULT_SYNC_SERVER, window.device, window.enableUnfinishedFeatures, WEBSOCKET_URL)
+  return window.startApplication(DEFAULT_SYNC_SERVER, window.device, window.enableUnfinishedFeatures, WEBSOCKET_URL)
 }
 
 window.onload = () => {
@@ -154,5 +154,5 @@ window.electronMainEvents.handleWindowFocused(() => {
 })
 
 window.electronMainEvents.handleInstallComponentComplete((_: IpcRendererEvent, data: any) => {
-  window.webClient.onComponentInstallationComplete(data.component, undefined)
+  void window.webClient.onComponentInstallationComplete(data.component, undefined)
 })

packages/desktop/linter.tsconfig.json

@@ -1,3 +0,0 @@
-{
-  "extends": "../../node_modules/@standardnotes/config/src/linter.tsconfig.json"
-}

packages/desktop/package.json

@@ -22,8 +22,8 @@
     "dev": "NODE_ENV=development webpack --config desktop.webpack.dev.js --watch",
     "format": "prettier --write .",
     "lint:eslint": "eslint app/index.ts app/application.ts app/javascripts/**/*.ts",
-    "lint:formatting": "prettier --check .",
-    "lint": "yarn lint:formatting && yarn lint:eslint",
+    "lint:formatting": "prettier --check app",
+    "lint": "yarn lint:formatting && yarn lint:eslint app",
     "tsc": "tsc --noEmit",
     "release:mac": "node scripts/build.mjs mac",
     "start": "electron ./app --enable-logging --icon _icon/icon.png",
@@ -58,7 +58,6 @@
     "@types/proxyquire": "^1.3.28",
     "@types/yauzl": "^2.10.0",
     "ava": "^4.3.3",
-    "babel-eslint": "^10.1.0",
     "babel-loader": "^8.2.5",
     "copy-webpack-plugin": "^10.2.4",
     "electron-builder": "23.3.3",