chore: fix eslint crashing issues (#1951)

.eslintrc.json

@@ -1,7 +0,0 @@
-{
-  "extends": ["./node_modules/@standardnotes/config/src/.eslintrc"],
-  "rules": {
-    "max-classes-per-file": ["error", 1]
-  },
-  "ignorePatterns": [".eslintrc.js", "*.webpack.*.js", "webpack-defaults.js", "jest.config.js", "__mocks__", "**/**/coverage"]
-}

common.eslintrc.js

@@ -0,0 +1,60 @@
+module.exports = {
+  root: true,
+  parser: '@typescript-eslint/parser',
+  extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended', 'prettier'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  plugins: ['@typescript-eslint', 'prettier'],
+  ignorePatterns: ['**/*.spec.ts'],
+  rules: {
+    'standard/no-callback-literal': 0, // Disable this as we have too many callbacks relying on literals
+    'no-throw-literal': 0,
+    camelcase: 'off',
+    'sort-imports': 'off',
+    'eol-last': 'error',
+    'no-multiple-empty-lines': ['error', { max: 1, maxEOF: 0 }],
+    'no-trailing-spaces': 'error',
+    '@typescript-eslint/no-explicit-any': 'warn',
+    '@typescript-eslint/no-unused-vars': [
+      'error',
+      {
+        vars: 'all',
+        args: 'after-used',
+        ignoreRestSiblings: false,
+        argsIgnorePattern: '^_',
+        varsIgnorePattern: '^_',
+      },
+    ],
+    '@typescript-eslint/no-floating-promises': ['error'],
+    'block-scoped-var': 'error',
+    'comma-dangle': ['error', 'always-multiline'],
+    curly: ['error', 'all'],
+    'no-confusing-arrow': 'error',
+    'no-inline-comments': 'warn',
+    'no-invalid-this': 'error',
+    'no-return-assign': 'warn',
+    'no-constructor-return': 'error',
+    'no-duplicate-imports': 'error',
+    'no-self-compare': 'error',
+    'no-console': ['error', { allow: ['warn', 'error'] }],
+    'no-unmodified-loop-condition': 'error',
+    'no-unused-private-class-members': 'error',
+    'object-curly-spacing': ['error', 'always'],
+    quotes: ['error', 'single', { avoidEscape: true }],
+    semi: ['error', 'never'],
+    'prettier/prettier': [
+      'error',
+      {
+        singleQuote: true,
+        trailingComma: 'all',
+        printWidth: 120,
+        semi: false,
+      },
+      {
+        usePrettierrc: false,
+      },
+    ],
+  },
+}

linter.tsconfig.json

@@ -1,4 +0,0 @@
-{
-  "exclude": ["node_modules"],
-  "extends": "./node_modules/@standardnotes/config/src/linter.tsconfig.json"
-}

packages/api/.eslintignore

@@ -1,3 +0,0 @@
-node_modules
-dist
-coverage

packages/api/.eslintrc

@@ -1,6 +0,0 @@
-{
-  "extends": "../../.eslintrc",
-  "parserOptions": {
-    "project": "./linter.tsconfig.json"
-  }
-}

packages/api/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/api/linter.tsconfig.json

@@ -1,4 +0,0 @@
-{
-  "extends": "./tsconfig.json",
-  "exclude": ["dist"]
-}

packages/api/package.json

@@ -21,8 +21,8 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
-    "lint:fix": "eslint . --ext .ts --fix",
+    "lint:fix": "eslint src --ext .ts --fix",
     "test": "jest spec --coverage"
   },
   "devDependencies": {

packages/desktop/.eslintignore

@@ -1,3 +0,0 @@
-node_modules
-dist
-jsign

packages/desktop/.eslintrc

@@ -1,16 +0,0 @@
-{
-  "env": {
-    "node": true,
-    "commonjs": true
-  },
-  "extends": ["../../.eslintrc.json"],
-  "rules": {
-    "no-console": "off",
-    "@typescript-eslint/no-explicit-any": "warn",
-    "@typescript-eslint/no-var-requires": "off"
-  },
-  "globals": {
-    "zip": true
-  },
-  "ignorePatterns": ["scripts"]
-}

packages/desktop/.eslintrc.js

@@ -0,0 +1,16 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts', '@types', 'node_modules', 'dist'],
+  rules: {
+    'no-console': ['warn', { allow: ['warn', 'error'] }],
+    '@typescript-eslint/no-var-requires': 'off',
+  },
+  globals: {
+    zip: true,
+  },
+}

packages/desktop/app/javascripts/Renderer/Renderer.ts

@@ -41,7 +41,7 @@ const loadAndStartApplication = async () => {
 
   window.device = await createDesktopDevice(remoteBridge)
 
-  window.startApplication(DEFAULT_SYNC_SERVER, window.device, window.enableUnfinishedFeatures, WEBSOCKET_URL)
+  return window.startApplication(DEFAULT_SYNC_SERVER, window.device, window.enableUnfinishedFeatures, WEBSOCKET_URL)
 }
 
 window.onload = () => {
@@ -154,5 +154,5 @@ window.electronMainEvents.handleWindowFocused(() => {
 })
 
 window.electronMainEvents.handleInstallComponentComplete((_: IpcRendererEvent, data: any) => {
-  window.webClient.onComponentInstallationComplete(data.component, undefined)
+  void window.webClient.onComponentInstallationComplete(data.component, undefined)
 })

packages/desktop/linter.tsconfig.json

@@ -1,3 +0,0 @@
-{
-  "extends": "../../node_modules/@standardnotes/config/src/linter.tsconfig.json"
-}

packages/desktop/package.json

@@ -22,8 +22,8 @@
     "dev": "NODE_ENV=development webpack --config desktop.webpack.dev.js --watch",
     "format": "prettier --write .",
     "lint:eslint": "eslint app/index.ts app/application.ts app/javascripts/**/*.ts",
-    "lint:formatting": "prettier --check .",
+    "lint:formatting": "prettier --check app",
-    "lint": "yarn lint:formatting && yarn lint:eslint",
+    "lint": "yarn lint:formatting && yarn lint:eslint app",
     "tsc": "tsc --noEmit",
     "release:mac": "node scripts/build.mjs mac",
     "start": "electron ./app --enable-logging --icon _icon/icon.png",
@@ -58,7 +58,6 @@
     "@types/proxyquire": "^1.3.28",
     "@types/yauzl": "^2.10.0",
     "ava": "^4.3.3",
-    "babel-eslint": "^10.1.0",
     "babel-loader": "^8.2.5",
     "copy-webpack-plugin": "^10.2.4",
     "electron-builder": "23.3.3",

packages/encryption/.eslintignore

@@ -1,2 +0,0 @@
-node_modules
-dist

packages/encryption/.eslintrc

@@ -1,10 +0,0 @@
-{
-  "extends": "../../.eslintrc",
-  "parserOptions": {
-    "project": "./linter.tsconfig.json"
-  },
-  "rules": {
-    "@typescript-eslint/no-explicit-any": ["warn", { "ignoreRestArgs": true }],
-    "@typescript-eslint/no-non-null-assertion": "warn"
-  }
-}

packages/encryption/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/encryption/linter.tsconfig.json

@@ -1,4 +0,0 @@
-{
-  "extends": "./tsconfig.json",
-  "exclude": ["dist"]
-}

packages/encryption/package.json

@@ -18,7 +18,7 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
     "format": "prettier --write src",
     "test": "jest"
   },

packages/features/.eslintignore

@@ -1,2 +0,0 @@
-node_modules
-dist

packages/features/.eslintrc

@@ -1,6 +0,0 @@
-{
-  "extends": "../../.eslintrc",
-  "parserOptions": {
-    "project": "./linter.tsconfig.json"
-  }
-}

packages/features/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/features/linter.tsconfig.json

@@ -1,4 +0,0 @@
-{
-  "extends": "./tsconfig.json",
-  "exclude": ["dist"]
-}

packages/features/package.json

@@ -21,7 +21,7 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
     "test": "jest"
   },
   "dependencies": {
@@ -32,7 +32,8 @@
   },
   "devDependencies": {
     "@types/jest": "^28.1.5",
-    "@typescript-eslint/eslint-plugin": "^5.30.0",
+    "@typescript-eslint/eslint-plugin": "*",
+    "eslint": "*",
     "eslint-plugin-prettier": "*",
     "jest": "^28.1.2",
     "ts-jest": "^28.0.5",

packages/filepicker/.eslintignore

@@ -1,3 +0,0 @@
-node_modules
-dist
-example

packages/filepicker/.eslintrc

@@ -1,6 +0,0 @@
-{
-  "extends": "../../.eslintrc",
-  "parserOptions": {
-    "project": "./linter.tsconfig.json"
-  }
-}

packages/filepicker/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/filepicker/example/package.json

@@ -24,7 +24,6 @@
     "@babel/preset-typescript": "^7.15.0",
     "@standardnotes/config": "^2.2.0",
     "@types/wicg-native-file-system": "^2020.6.0",
-    "babel-eslint": "^10.1.0",
     "babel-loader": "^8.2.3",
     "html-webpack-plugin": "^5.5.0",
     "ts-loader": "^9.2.6",

packages/filepicker/linter.tsconfig.json

@@ -1,4 +0,0 @@
-{
-  "extends": "./tsconfig.json",
-  "exclude": ["dist", "example"]
-}

packages/filepicker/package.json

@@ -19,12 +19,13 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
     "test": "jest"
   },
   "devDependencies": {
     "@types/jest": "^28.1.5",
     "@typescript-eslint/eslint-plugin": "^5.30.0",
+    "eslint": "*",
     "eslint-plugin-prettier": "*",
     "jest": "^28.1.2",
     "ts-jest": "^28.0.5",

packages/files/.eslintignore

@@ -1,2 +0,0 @@
-node_modules
-dist

packages/files/.eslintrc

@@ -1,6 +0,0 @@
-{
-  "extends": "../../.eslintrc",
-  "parserOptions": {
-    "project": "./linter.tsconfig.json"
-  }
-}

packages/files/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/files/linter.tsconfig.json

@@ -1,4 +0,0 @@
-{
-  "extends": "./tsconfig.json",
-  "exclude": ["dist"]
-}

packages/files/package.json

@@ -19,12 +19,13 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
     "test": "jest"
   },
   "devDependencies": {
     "@types/jest": "^28.1.5",
     "@typescript-eslint/eslint-plugin": "^5.30.0",
+    "eslint": "*",
     "eslint-plugin-prettier": "*",
     "jest": "^28.1.2",
     "ts-jest": "^28.0.5"

packages/mobile/.eslintignore

@@ -1,9 +0,0 @@
-metro.config.js
-html/**/*
-node_modules
-ios
-e2e
-android
-fastlane
-WebFrame
-__tests__

packages/mobile/.eslintrc

@@ -1,14 +0,0 @@
-{
-  "env": {
-    "node": true,
-    "commonjs": true
-  },
-  "extends": ["@react-native-community", "plugin:react-hooks/recommended", "../../.eslintrc.json"],
-  "rules": {
-    "no-console": "warn",
-    "@typescript-eslint/no-explicit-any": "warn",
-    "@typescript-eslint/no-var-requires": "off",
-    "eqeqeq": ["off"],
-    "no-void": ["off"]
-  }
-}

packages/mobile/.eslintrc.js

@@ -0,0 +1,13 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js', 'plugin:react-hooks/recommended'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts', '__mocks__'],
+  plugins: ['@typescript-eslint', 'react', 'react-hooks', 'prettier'],
+  rules: {
+    'no-console': 'warn',
+  }
+}

packages/mobile/package.json

@@ -17,7 +17,7 @@
     "ios-dev": "react-native run-ios --scheme StandardNotesDev",
     "ios-prod": "react-native run-ios --scheme StandardNotes",
     "lint:fix": "yarn lint --fix",
-    "lint": "yarn tsc && yarn eslint . --ext .ts,.tsx",
+    "lint": "yarn eslint src --ext .ts,.tsx",
     "pods": "yarn install:pods",
     "start": "react-native start",
     "tsc": "tsc --noEmit",

packages/mobile/tsconfig.json

@@ -17,16 +17,5 @@
     "target": "esnext",
     "typeRoots": ["node_modules/@types", "./src/Types/*"]
   },
-  "exclude": [
+  "include": ["src"]
-    "node_modules",
-    "babel.config.js",
-    "metro.config.js",
-    "jest.config.js",
-    "e2e",
-    "html",
-    "android",
-    "WebFrame",
-    "ios",
-    "fastlane"
-  ]
 }

packages/models/.eslintignore

@@ -1,2 +0,0 @@
-node_modules
-dist

packages/models/.eslintrc

@@ -1,10 +0,0 @@
-{
-  "extends": "../../.eslintrc",
-  "parserOptions": {
-    "project": "./linter.tsconfig.json"
-  },
-  "rules": {
-    "@typescript-eslint/no-explicit-any": ["warn", { "ignoreRestArgs": true }],
-    "@typescript-eslint/no-non-null-assertion": "warn"
-  }
-}

packages/models/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/models/linter.tsconfig.json

@@ -1,4 +0,0 @@
-{
-  "extends": "./tsconfig.json",
-  "exclude": ["dist"]
-}

packages/models/package.json

@@ -18,7 +18,7 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
     "test": "jest"
   },
   "devDependencies": {

packages/models/tsconfig.json

@@ -9,5 +9,5 @@
     "src/**/*"
   ],
   "references": [],
-  "exclude": ["**/*.spec.ts", "dist", "node_modules"]
+  "exclude": ["**/*.spec.ts"]
 }

packages/responses/.eslintignore

@@ -1,3 +0,0 @@
-node_modules
-dist
-coverage

packages/responses/.eslintrc

@@ -1,6 +0,0 @@
-{
-  "extends": "../../.eslintrc",
-  "parserOptions": {
-    "project": "./linter.tsconfig.json"
-  }
-}

packages/responses/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/responses/linter.tsconfig.json

@@ -1,4 +0,0 @@
-{
-  "extends": "./tsconfig.json",
-  "exclude": ["dist"]
-}

packages/responses/package.json

@@ -20,12 +20,13 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
     "test": "jest spec --coverage --passWithNoTests"
   },
   "devDependencies": {
     "@types/jest": "^28.1.5",
     "@typescript-eslint/eslint-plugin": "^5.30.0",
+    "eslint": "*",
     "eslint-plugin-prettier": "*",
     "jest": "^28.1.2",
     "ts-jest": "^28.0.5"

packages/services/.eslintignore

@@ -1,3 +0,0 @@
-node_modules
-dist
-coverage

packages/services/.eslintrc

@@ -1,9 +0,0 @@
-{
-  "extends": "../../.eslintrc",
-  "parserOptions": {
-    "project": "./linter.tsconfig.json"
-  },
-  "rules": {
-    "@typescript-eslint/no-explicit-any": ["warn", { "ignoreRestArgs": true }]
-  }
-}

packages/services/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/services/linter.tsconfig.json

@@ -1,4 +0,0 @@
-{
-  "extends": "./tsconfig.json",
-  "exclude": ["dist"]
-}

packages/services/package.json

@@ -19,8 +19,8 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
-    "lint:fix": "eslint . --ext .ts --fix",
+    "lint:fix": "eslint src --ext .ts --fix",
     "test": "jest spec --coverage"
   },
   "dependencies": {

packages/sncrypto-common/.eslintignore

@@ -1 +0,0 @@
-dist

packages/sncrypto-common/.eslintrc

@@ -1,6 +0,0 @@
-{
-  "extends": "../../.eslintrc",
-  "parserOptions": {
-    "project": "./linter.tsconfig.json"
-  }
-}

packages/sncrypto-common/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/sncrypto-common/linter.tsconfig.json

@@ -1,4 +0,0 @@
-{
-  "extends": "./tsconfig.json",
-  "exclude": ["dist"]
-}

packages/sncrypto-common/package.json

@@ -20,12 +20,13 @@
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
     "watch": "tsc -p tsconfig.json --watch",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
     "test": "yarn lint"
   },
   "devDependencies": {
     "@typescript-eslint/eslint-plugin": "^5.30.0",
     "@typescript-eslint/parser": "^5.12.1",
+    "eslint": "*",
     "eslint-plugin-prettier": "^4.2.1",
     "typescript": "*"
   },

packages/sncrypto-web/.eslintignore

@@ -1,4 +0,0 @@
-dist
-test
-*.config.js
-test-server.js

packages/sncrypto-web/.eslintrc

@@ -1,6 +0,0 @@
-{
-  "extends": "../../.eslintrc",
-  "parserOptions": {
-    "project": "./linter.tsconfig.json"
-  }
-}

packages/sncrypto-web/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/sncrypto-web/linter.tsconfig.json

@@ -1,4 +0,0 @@
-{
-  "extends": "./tsconfig.json",
-  "exclude": ["dist"]
-}

packages/sncrypto-web/package.json

@@ -19,7 +19,7 @@
     "prebuild": "yarn clean",
     "build": "webpack --mode production && tsc",
     "watch": "webpack --mode production --watch",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
     "test:e2e": "node test-server.js"
   },
   "dependencies": {

packages/snjs/.eslintignore

@@ -1,9 +0,0 @@
-node_modules
-dist
-test
-*.config.js
-mocha/**/*
-coverage
-e2e-server.js
-jest-global.ts
-webpack.*.js

packages/snjs/.eslintrc

@@ -1,9 +0,0 @@
-{
-  "extends": "../../.eslintrc.json",
-  "parserOptions": {
-    "project": "./linter.tsconfig.json"
-  },
-  "rules": {
-    "@typescript-eslint/no-explicit-any": ["warn", { "ignoreRestArgs": true }]
-  }
-}

packages/snjs/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './lib/tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/snjs/jsdoc.json

@@ -1,22 +0,0 @@
-{
-  "source": {
-    "includePattern": ".+\\.js(doc|x)?$",
-    "include": ["lib"],
-    "exclude": ["node_modules"]
-  },
-  "recurseDepth": 10,
-  "opts": {
-    "destination": "./docs/",
-    "recurse": true,
-    "template": "node_modules/docdash"
-  },
-  "tags": {
-    "allowUnknownTags": true,
-    "dictionaries": ["jsdoc", "closure"]
-  },
-  "docdash": {
-    "meta": {
-      "title": "SNJS Documentation"
-    }
-  }
-}

packages/snjs/package.json

@@ -24,7 +24,7 @@
     "build": "yarn tsc && webpack --config webpack.prod.js",
     "docs": "jsdoc -c jsdoc.json",
     "tsc": "tsc --project lib/tsconfig.json && tscpaths -p lib/tsconfig.json -s lib -o dist/@types",
-    "lint": "yarn lint:tsc && yarn lint:eslint",
+    "lint": "yarn lint:eslint lib",
     "lint:eslint": "eslint --ext .ts lib/",
     "lint:fix": "eslint --fix --ext .ts lib/",
     "lint:tsc": "tsc --noEmit --emitDeclarationOnly false --project lib/tsconfig.json",

packages/styles/.eslintignore

@@ -1,3 +0,0 @@
-node_modules
-dist
-webpack.config.js

packages/styles/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/styles/.eslintrc.json

@@ -1,4 +0,0 @@
-{
-  "extends": ["../../node_modules/@standardnotes/config/src/.eslintrc"],
-  "ignorePatterns": [".eslintrc.js", "webpack.config.js"]
-}

packages/styles/linter.tsconfig.json

@@ -1,3 +0,0 @@
-{
-  "extends": "../../node_modules/@standardnotes/config/src/linter.tsconfig.json"
-}

packages/toast/.eslintignore

@@ -1,2 +0,0 @@
-node_modules
-dist

packages/toast/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/toast/.eslintrc.json

@@ -1,4 +0,0 @@
-{
-  "extends": ["../../node_modules/@standardnotes/config/src/.eslintrc"],
-  "ignorePatterns": [".eslintrc.js", "*.webpack.*.js", "webpack-defaults.js", "jest.config.js", "__mocks__"]
-}

packages/toast/linter.tsconfig.json

@@ -1,3 +0,0 @@
-{
-  "extends": "../../node_modules/@standardnotes/config/src/linter.tsconfig.json"
-}

packages/ui-services/.eslintignore

@@ -1,3 +0,0 @@
-node_modules
-dist
-coverage

packages/ui-services/.eslintrc

@@ -1,9 +0,0 @@
-{
-  "extends": "../../.eslintrc",
-  "parserOptions": {
-    "project": "./linter.tsconfig.json"
-  },
-  "rules": {
-    "@typescript-eslint/no-explicit-any": ["warn", { "ignoreRestArgs": true }]
-  }
-}

packages/ui-services/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/ui-services/linter.tsconfig.json

@@ -1,4 +0,0 @@
-{
-  "extends": "./tsconfig.json",
-  "exclude": ["dist"]
-}

packages/ui-services/package.json

@@ -19,7 +19,7 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
     "test": "jest spec"
   },
   "dependencies": {
@@ -35,6 +35,7 @@
     "@types/jest": "^28.1.5",
     "@typescript-eslint/eslint-plugin": "^5.30.0",
     "@typescript-eslint/parser": "^5.12.1",
+    "eslint": "*",
     "eslint-plugin-prettier": "*",
     "jest": "^28.1.2",
     "ts-jest": "^28.0.5",

packages/utils/.eslintignore

@@ -1,2 +0,0 @@
-node_modules
-dist

packages/utils/.eslintrc

@@ -1,6 +0,0 @@
-{
-  "extends": "../../.eslintrc",
-  "parserOptions": {
-    "project": "./linter.tsconfig.json"
-  }
-}

packages/utils/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/utils/linter.tsconfig.json

@@ -1,4 +0,0 @@
-{
-  "extends": "./tsconfig.json",
-  "exclude": ["dist"]
-}

packages/utils/package.json

@@ -21,7 +21,7 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
     "test": "jest spec"
   },
   "dependencies": {
@@ -37,6 +37,7 @@
     "@types/lodash": "^4.14.179",
     "@types/node": "^18.0.0",
     "@typescript-eslint/eslint-plugin": "^5.30.0",
+    "eslint": "*",
     "eslint-plugin-prettier": "*",
     "jest": "^28.1.2",
     "jsdom": "^20.0.0",

packages/web/.eslintignore

@@ -1,7 +0,0 @@
-dist
-node_modules
-web.webpack-defaults.js
-coverage
-src/components
-src/favicon
-src/vendor

packages/web/.eslintrc

@@ -1,47 +0,0 @@
-{
-  "root": true,
-  "parser": "@typescript-eslint/parser",
-  "extends": [
-    "eslint:recommended",
-    "plugin:@typescript-eslint/recommended",
-    "prettier",
-    "plugin:react-hooks/recommended",
-    "../../node_modules/@standardnotes/config/src/.eslintrc"
-  ],
-  "plugins": ["@typescript-eslint", "react", "react-hooks"],
-  "ignorePatterns": [
-    "node_modules",
-    "dist",
-    ".eslintrc.js",
-    "*.webpack.*.js",
-    "webpack-defaults.js",
-    "jest.config.js",
-    "__mocks__",
-    "src/components",
-    "src/favicon",
-    "src/vendor",
-    "coverage",
-    "*.config.js"
-  ],
-  "rules": {
-    "standard/no-callback-literal": 0, // Disable this as we have too many callbacks relying on literals
-    "no-throw-literal": 0,
-    "no-console": ["warn", { "allow": ["warn", "error"] }],
-    "semi": 1,
-    "camelcase": "warn",
-    "sort-imports": "off",
-    "react-hooks/rules-of-hooks": "error",
-    "react-hooks/exhaustive-deps": "error",
-    "eol-last": "error",
-    "no-multiple-empty-lines": ["error", { "max": 1, "maxEOF": 0 }],
-    "no-trailing-spaces": "error",
-    "@typescript-eslint/no-explicit-any": "warn",
-    "no-invalid-this": "warn"
-  },
-  "env": {
-    "browser": true
-  },
-  "globals": {
-    "__WEB_VERSION__": true
-  }
-}

packages/web/.eslintrc.js

@@ -0,0 +1,16 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js', 'plugin:react-hooks/recommended'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts', "__mocks__"],
+  plugins: ['@typescript-eslint', 'react', 'react-hooks', 'prettier'],
+  env: {
+    browser: true,
+  },
+  globals: {
+    __WEB_VERSION__: true,
+  },
+}

packages/web/src/javascripts/Components/ComponentView/ComponentView.tsx

@@ -48,7 +48,7 @@ const ComponentView: FunctionComponent<IProps> = ({ application, onLoad, compone
   const component: SNComponent = componentViewer.component
 
   const manageSubscription = useCallback(() => {
-    openSubscriptionDashboard(application)
+    void openSubscriptionDashboard(application)
   }, [application])
 
   const reloadValidityStatus = useCallback(() => {

packages/web/src/javascripts/Components/ContentListView/ContentListView.tsx

@@ -214,9 +214,9 @@ const ContentListView: FunctionComponent<Props> = ({
   const panelResizeFinishCallback: ResizeFinishCallback = useCallback(
     (width, _lastLeft, _isMaxWidth, isCollapsed) => {
       if (selectedAsTag) {
-        navigationController.setPanelWidthForTag(selectedAsTag, width)
+        void navigationController.setPanelWidthForTag(selectedAsTag, width)
       } else {
-        application.setPreference(PrefKey.NotesPanelWidth, width).catch(console.error)
+        void application.setPreference(PrefKey.NotesPanelWidth, width).catch(console.error)
       }
       application.publishPanelDidResizeEvent(PANEL_NAME_NOTES, isCollapsed)
     },

packages/web/src/javascripts/Components/ContentListView/Daily/DailyContentList.tsx

@@ -113,7 +113,7 @@ const DailyContentList: FunctionComponent<Props> = ({
   const onClickTemplate = useCallback(
     (date: Date) => {
       setSelectedDay(date)
-      itemListController.createNewNote(undefined, date, 'editor')
+      void itemListController.createNewNote(undefined, date, 'editor')
       toggleAppPane(AppPaneId.Editor)
     },
     [setSelectedDay, itemListController, toggleAppPane],

packages/web/src/javascripts/Components/ContentListView/Header/DisplayOptionsMenu.tsx

@@ -101,7 +101,7 @@ const DisplayOptionsMenu: FunctionComponent<DisplayOptionsMenuProps> = ({
   )
 
   const resetTagPreferences = useCallback(() => {
-    application.mutator.changeAndSaveItem<TagMutator>(selectedTag, (mutator) => {
+    void application.mutator.changeAndSaveItem<TagMutator>(selectedTag, (mutator) => {
       mutator.preferences = undefined
     })
   }, [application, selectedTag])

packages/web/src/javascripts/Components/ContentListView/Header/NewNotePreferences.tsx

@@ -101,7 +101,7 @@ const NewNotePreferences: FunctionComponent<Props> = ({
   const setNewNoteTitleFormatChange = (value: string) => {
     setNewNoteTitleFormat(value as NewNoteTitleFormat)
     if (mode === 'global') {
-      application.setPreference(PrefKey.NewNoteTitleFormat, value as NewNoteTitleFormat)
+      void application.setPreference(PrefKey.NewNoteTitleFormat, value as NewNoteTitleFormat)
     } else {
       void changePreferencesCallback({ newNoteTitleFormat: value as NewNoteTitleFormat })
     }
@@ -168,7 +168,7 @@ const NewNotePreferences: FunctionComponent<Props> = ({
       if (mode === 'tag') {
         void changePreferencesCallback({ customNoteTitleFormat: newFormat })
       } else {
-        application.setPreference(PrefKey.CustomNoteTitleFormat, newFormat)
+        void application.setPreference(PrefKey.CustomNoteTitleFormat, newFormat)
       }
     }, PrefChangeDebounceTimeInMs)
   }

packages/web/src/javascripts/Components/FilePreview/PreviewComponent.tsx

@@ -50,7 +50,7 @@ const PreviewComponent: FunctionComponent<Props> = ({ application, file, bytes }
       }),
     )
 
-    application.mobileDevice().previewFile(fileBase64, file.name)
+    void application.mobileDevice().previewFile(fileBase64, file.name)
   }, [application, bytes, file.mimeType, file.name, isNativeMobileWeb])
 
   useEffect(() => {

packages/web/src/javascripts/Components/LinkedItems/LinkedItemBubble.tsx

@@ -61,14 +61,14 @@ const LinkedItemBubble = ({
 
   const onUnlinkClick: MouseEventHandler = (event) => {
     event.stopPropagation()
-    unlinkItem(link)
+    void unlinkItem(link)
   }
 
   const onKeyDown: KeyboardEventHandler = (event) => {
     switch (event.key) {
       case KeyboardKey.Backspace: {
         focusPreviousItem()
-        unlinkItem(link)
+        void unlinkItem(link)
         break
       }
       case KeyboardKey.Left: