rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix issue where when editor duplicated, endless activation loop would result upon editor activation handler

Browse Source
This commit is contained in:
Mo Bitar
2018-09-14 10:15:53 -05:00
parent 2cbc6e7bb2
commit 694f760540
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/assets/javascripts/app/controllers/editor.js
View File

@@ -554,7 +554,10 @@ angular.module('app')
}
else if(this.selectedEditor) {
if(this.selectedEditor.active) {
if(component.isExplicitlyEnabledForItem(this.note)) {
// In the case where an editor is duplicated, then you'll have two editors who are explicitely enabled for the same note.
// This will cause an infinite loop, where as soon as the first is enabled, the second will come in, pass the `isExplicitlyEnabledForItem` check,
// and replace the previous one. So we now check to make the current editor isn't also explicitely enabled, and if it is, then we'll just keep that one active.
if(component.isExplicitlyEnabledForItem(this.note) && !this.selectedEditor.isExplicitlyEnabledForItem(this.note)) {
this.selectedEditor = component;
}
}