fix: select on focus, wait for value

app/assets/javascripts/app.ts

@@ -26,7 +26,7 @@ import {
   fileChange,
   infiniteScroll,
   lowercase,
-  selectOnClick,
+  selectOnFocus,
   snEnter
 } from './directives/functional';
 
@@ -79,7 +79,7 @@ angular
   .directive('fileChange', fileChange)
   .directive('infiniteScroll', [infiniteScroll])
   .directive('lowercase', lowercase)
-  .directive('selectOnClick', ['$window', selectOnClick])
+  .directive('selectOnFocus', ['$window', selectOnFocus])
   .directive('snEnter', snEnter);
 
 // Directives - Views

app/assets/javascripts/directives/functional/index.ts

@@ -5,5 +5,5 @@ export { elemReady } from './elemReady';
 export { fileChange } from './file-change';
 export { infiniteScroll } from './infiniteScroll';
 export { lowercase } from './lowercase';
-export { selectOnClick } from './selectOnClick';
+export { selectOnFocus } from './selectOnFocus';
 export { snEnter } from './snEnter';

app/assets/javascripts/directives/functional/selectOnClick.ts

@@ -1,15 +0,0 @@
-/* @ngInject */
-export function selectOnClick($window: ng.IWindowService) {
-  return {
-    restrict: 'A',
-    link: function(scope: ng.IScope, element: JQLite) {
-      element.on('focus', () => {
-        if (!$window.getSelection()!.toString()) {
-          const input = element[0] as HTMLInputElement;
-          /** Required for mobile Safari */
-          input.setSelectionRange(0, input.value.length);
-        }
-      });
-    }
-  };
-}

app/assets/javascripts/directives/functional/selectOnFocus.ts

@@ -0,0 +1,17 @@
+/* @ngInject */
+export function selectOnFocus($window: ng.IWindowService) {
+  return {
+    restrict: 'A',
+    link: function (scope: ng.IScope, element: JQLite) {
+      element.on('focus', () => {
+        if (!$window.getSelection()!.toString()) {
+          const input = element[0] as HTMLInputElement;
+          /** Allow text to populate */
+          setImmediate(() => {
+            input.setSelectionRange(0, input.value.length);
+          })
+        }
+      });
+    }
+  };
+}

app/assets/javascripts/views/editor/editor-view.pug

@@ -23,8 +23,9 @@
         ng-focus='self.onTitleFocus()', 
         ng-keyup='$event.keyCode == 13 && self.onTitleEnter($event)', 
         ng-model='self.editorValues.title', 
-        select-on-click='true', 
-        spellcheck='false')
+        select-on-focus='true',
+        spellcheck='false'
+        )
     #save-status
       .message(
         ng-class="{'warning sk-bold': self.state.syncTakingTooLong, 'danger sk-bold': self.state.saveError}"

app/assets/javascripts/views/notes/notes-view.pug

@@ -17,7 +17,7 @@
             ng-keyup='$event.keyCode == 13 && self.onFilterEnter();',
             ng-model='self.state.noteFilter.text',
             placeholder='Search',
-            select-on-click='true',
+            select-on-focus='true',
             title='Searches notes in the currently selected tag'
             )
           #search-clear-button(