fix: panel resizer callback

This commit is contained in:
Mo Bitar
2020-04-22 08:32:51 -05:00
parent 2ce981a1ea
commit 7a615bc137
8 changed files with 38 additions and 27 deletions

View File

@@ -37,7 +37,7 @@ interface PanelResizerScope {
hoverable: boolean
index: number
minWidth: number
onResizeFinish: ResizeFinishCallback
onResizeFinish: () => ResizeFinishCallback
panelId: string
property: PanelSide
}
@@ -52,7 +52,7 @@ class PanelResizerCtrl implements PanelResizerScope {
hoverable!: boolean
index!: number
minWidth!: number
onResizeFinish!: ResizeFinishCallback
onResizeFinish!: () => ResizeFinishCallback
panelId!: string
property!: PanelSide
@@ -195,7 +195,7 @@ class PanelResizerCtrl implements PanelResizerScope {
}
this.finishSettingWidth();
const newCollapseState = !preClickCollapseState;
this.onResizeFinish(
this.onResizeFinish()(
this.lastWidth,
this.lastLeft,
this.isAtMaxWidth(),
@@ -227,7 +227,7 @@ class PanelResizerCtrl implements PanelResizerScope {
this.panel.classList.remove(CssClass.NoSelection);
const isMaxWidth = this.isAtMaxWidth();
if (this.onResizeFinish) {
this.onResizeFinish(
this.onResizeFinish()(
this.lastWidth,
this.lastLeft,
isMaxWidth,

View File

@@ -45,7 +45,7 @@ export class PreferencesManager extends ApplicationService {
predicate,
contentType,
FillItemContent({})
)) as SNUserPrefs;
)) as SNUserPrefs;
this.loadingPrefs = false;
const didChange = !previousRef || (
this.userPreferences.lastSyncBegan?.getTime() !== previousRef?.lastSyncBegan?.getTime()

View File

@@ -199,7 +199,7 @@
hoverable='true',
min-width='300',
ng-if='self.state.marginResizersEnabled',
on-resize-finish='self.onPanelResizeFinish()',
on-resize-finish='self.onPanelResizeFinish',
panel-id="'editor-content'",
property="'left'"
)
@@ -226,7 +226,7 @@
control='self.rightPanelPuppet',
hoverable='true', min-width='300',
ng-if='self.state.marginResizersEnabled',
on-resize-finish='self.onPanelResizeFinish()',
on-resize-finish='self.onPanelResizeFinish',
panel-id="'editor-content'",
property="'right'"
)

View File

@@ -107,13 +107,17 @@ class FooterViewCtrl extends PureViewCtrl {
async onAppLaunch() {
super.onAppLaunch();
this.reloadPasscodeStatus();
this.reloadUser();
this.reloadUpgradeStatus();
this.user = this.application!.getUser();
this.updateOfflineStatus();
this.findErrors();
this.streamItems();
this.registerComponentHandler();
}
reloadUser() {
this.user = this.application!.getUser();
}
async reloadPasscodeStatus() {
const hasPasscode = this.application!.hasPasscode();
@@ -193,6 +197,11 @@ class FooterViewCtrl extends PureViewCtrl {
} else if (eventName === ApplicationEvent.FailedSync) {
this.findErrors();
this.updateOfflineStatus();
} else if (
eventName === ApplicationEvent.SignedIn ||
eventName === ApplicationEvent.SignedOut
) {
this.reloadUser();
}
}

View File

@@ -137,6 +137,6 @@
control="self.panelPuppet"
default-width="300"
hoverable="true"
on-resize-finish="self.onPanelResize()"
on-resize-finish="self.onPanelResize"
panel-id="'notes-column'"
)

View File

@@ -67,6 +67,6 @@
control='self.panelPuppet',
default-width='150',
hoverable='true',
on-resize-finish='self.onPanelResize()',
on-resize-finish='self.onPanelResize',
panel-id="'tags-column'"
)

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long