chore: fix session modal error after revoking session

This commit is contained in:
Aman Harwara
2023-06-30 20:56:48 +05:30
parent a0bc6153d6
commit c9a95c818b
2 changed files with 6 additions and 8 deletions

View File

@@ -1,6 +1,6 @@
import { ViewControllerManager } from '@/Controllers/ViewControllerManager' import { ViewControllerManager } from '@/Controllers/ViewControllerManager'
import { SNApplication, SessionStrings, UuidString, SessionListEntry, isErrorResponse } from '@standardnotes/snjs' import { SNApplication, SessionStrings, UuidString, SessionListEntry, isErrorResponse } from '@standardnotes/snjs'
import { FunctionComponent, useState, useEffect, useRef, useMemo, useCallback } from 'react' import { FunctionComponent, useState, useEffect, useRef, useMemo } from 'react'
import { WebApplication } from '@/Application/WebApplication' import { WebApplication } from '@/Application/WebApplication'
import { observer } from 'mobx-react-lite' import { observer } from 'mobx-react-lite'
import Spinner from '@/Components/Spinner/Spinner' import Spinner from '@/Components/Spinner/Spinner'
@@ -80,8 +80,6 @@ const SessionsModalContent: FunctionComponent<{
viewControllerManager: ViewControllerManager viewControllerManager: ViewControllerManager
application: SNApplication application: SNApplication
}> = ({ viewControllerManager, application }) => { }> = ({ viewControllerManager, application }) => {
const close = useCallback(() => viewControllerManager.closeSessionsModal(), [viewControllerManager])
const [sessions, refresh, refreshing, revokeSession, errorMessage] = useSessions(application) const [sessions, refresh, refreshing, revokeSession, errorMessage] = useSessions(application)
const [confirmRevokingSessionUuid, setRevokingSessionUuid] = useState('') const [confirmRevokingSessionUuid, setRevokingSessionUuid] = useState('')
@@ -109,7 +107,7 @@ const SessionsModalContent: FunctionComponent<{
(): ModalAction[] => [ (): ModalAction[] => [
{ {
label: 'Close', label: 'Close',
onClick: close, onClick: viewControllerManager.closeSessionsModal,
type: 'cancel', type: 'cancel',
mobileSlot: 'left', mobileSlot: 'left',
}, },
@@ -120,14 +118,14 @@ const SessionsModalContent: FunctionComponent<{
mobileSlot: 'right', mobileSlot: 'right',
}, },
], ],
[close, refresh], [refresh, viewControllerManager.closeSessionsModal],
) )
return ( return (
<> <>
<Modal <Modal
title="Active Sessions" title="Active Sessions"
close={close} close={viewControllerManager.closeSessionsModal}
actions={sessionModalActions} actions={sessionModalActions}
className={{ className={{
content: 'sessions-modal', content: 'sessions-modal',

View File

@@ -263,11 +263,11 @@ export class ViewControllerManager implements InternalEventHandlerInterface {
destroyAllObjectProperties(this) destroyAllObjectProperties(this)
} }
openSessionsModal(): void { openSessionsModal = () => {
this.isSessionsModalVisible = true this.isSessionsModalVisible = true
} }
closeSessionsModal(): void { closeSessionsModal = () => {
this.isSessionsModalVisible = false this.isSessionsModalVisible = false
} }