rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: fix tag options menu opening notes list [skip e2e]

Browse Source
This commit is contained in:
Aman Harwara
2023-10-29 14:41:37 +05:30
parent 00d30ca003
commit f3a9717883
3 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/web/src/javascripts/Components/Tags/SmartViewsListItem.tsx
View File

@@ -115,7 +115,7 @@ const SmartViewsListItem: FunctionComponent<Props> = ({ view, tagsState, setEdit
<div <div
role="button" role="button"
tabIndex={FOCUSABLE_BUT_NOT_TABBABLE} tabIndex={FOCUSABLE_BUT_NOT_TABBABLE}
className={classNames('tag group px-3.5', isSelected && 'selected', isFaded && 'opacity-50')} className={classNames('tag group px-3.5 py-1 md:py-0', isSelected && 'selected', isFaded && 'opacity-50')}
onClick={selectCurrentTag} onClick={selectCurrentTag}
onContextMenu={(event) => { onContextMenu={(event) => {
event.preventDefault() event.preventDefault()

4
packages/web/src/javascripts/Components/Tags/TagsList.tsx
View File

@@ -30,7 +30,9 @@ const TagsList: FunctionComponent<Props> = ({ type }: Props) => {
const onContextMenu = useCallback( const onContextMenu = useCallback(
(tag: SNTag, posX: number, posY: number) => { (tag: SNTag, posX: number, posY: number) => {
void application.navigationController.setSelectedTag(tag, type) if (application.navigationController.selected !== tag) {
void application.navigationController.setSelectedTag(tag, type)
}
openTagContextMenu(posX, posY) openTagContextMenu(posX, posY)
}, },
[application, openTagContextMenu, type], [application, openTagContextMenu, type],

6
packages/web/src/javascripts/Components/Tags/TagsListItem.tsx
View File

@@ -260,7 +260,11 @@ export const TagsListItem: FunctionComponent<Props> = observer(
<div <div
role="button" role="button"
tabIndex={FOCUSABLE_BUT_NOT_TABBABLE} tabIndex={FOCUSABLE_BUT_NOT_TABBABLE}
className={classNames('tag group px-3.5', isSelected && 'selected', isBeingDraggedOver && 'is-drag-over')} className={classNames(
'tag group px-3.5 py-1 md:py-0',
isSelected && 'selected',
isBeingDraggedOver && 'is-drag-over',
)}
onClick={selectCurrentTag} onClick={selectCurrentTag}
ref={tagRef} ref={tagRef}
style={{ style={{