rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove footer component active persistence, so that if a modal or the Extensions window is opened on one computer, it doesn't open on another computer. The inspiration for this was since opening and closing the Ext window no longer syncs the .active state of that window, if the Extensions ext is for whatever reason synced while it was open, setting .active to true, then, it's impossible to reset that flag. So it will perpetually open and nothing cna be done about it.

Browse Source
This commit is contained in:
Mo Bitar
2018-04-28 11:14:34 -05:00
parent d660624740
commit e2ee69ba6f
1 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
app/assets/javascripts/app/controllers/footer.js
View File

@@ -129,18 +129,9 @@ angular.module('app')
});
componentManager.registerHandler({identifier: "roomBar", areas: ["rooms", "modal"], activationHandler: (component) => {
if(component.active) {
// Show room, if it was not activated manually (in the event of event from componentManager)
if(component.area == "rooms" && !component.showRoom) {
component.showRoom = true;
}
$timeout(() => {
var lastSize = component.getLastSize();
if(lastSize) {
componentManager.handleSetSizeEvent(component, lastSize);
}
});
}
// RIP: There used to be code here that checked if component.active was true, and if so, displayed the component.
// However, we no longer want to persist active state for footer extensions. If you open Extensions on one computer,
// it shouldn't open on another computer. Active state should only be persisted for persistent extensions, like Folders.
}, actionHandler: (component, action, data) => {
if(action == "set-size") {
component.setLastSize(data);